fix: Explicit filepath #1769
Merged
fix: Explicit filepath #1769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. ESM support has changed out from underneath us since we did the initial switch to ESM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You are not truly using ESM unless you are not specifying the extension.
you are compiling to commonjs after all...
remote http path resolver (like http-import) don't have access to the filesystem and can't resolve
./footo./foo.jsor./foo/index.jsit's unable to guess what you meanthttps://nodejs.org/docs/latest-v17.x/api/esm.html#mandatory-file-extensions
the only thing i think you have left to do is adding
"type": "module"in package.json and stop generating cjs/umd and just output esm, but this is up to you - at least now this is more cdn friendly