Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): fix code example in docs #1703

Merged
merged 1 commit into from Feb 16, 2020
Merged

Conversation

juanarbol
Copy link
Contributor

No description provided.

Copy link
Collaborator

@aearly aearly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a generated file. Can you fix in in the source?

@juanarbol
Copy link
Contributor Author

Sure.

@juanarbol juanarbol force-pushed the docs-changes branch 2 times, most recently from 53a6892 to e734c8c Compare February 3, 2020 01:37
@juanarbol
Copy link
Contributor Author

I ran npm run jsdoc but a lot of files got modified, so I just left the source changed.

@juanarbol
Copy link
Contributor Author

Should I close this?

@aearly
Copy link
Collaborator

aearly commented Feb 16, 2020

No this is fine, i'll update it in the next release.

@aearly aearly merged commit 2f329d0 into caolan:master Feb 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants