Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid eval in async wrappers; fixes #1403 #1404

Merged
merged 1 commit into from Apr 17, 2017
Merged

Avoid eval in async wrappers; fixes #1403 #1404

merged 1 commit into from Apr 17, 2017

Conversation

megawac
Copy link
Collaborator

@megawac megawac commented Apr 17, 2017

No description provided.

aearly
aearly approved these changes Apr 17, 2017
View reviewed changes
Copy link
Collaborator

@aearly aearly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I think I was trying to be too clever here. V8 will eventually optimize wrapAsync to identity on unsupported platforms anyway.

@megawac megawac merged commit 996abc2 into master Apr 17, 2017
@megawac megawac deleted the avoid-eval branch April 17, 2017 18:43
@dependabot-preview dependabot-preview bot mentioned this pull request Mar 21, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aearly aearly aearly approved these changes

@hargasinski hargasinski Awaiting requested review from hargasinski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@megawac @aearly