Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print the name of the actual missing dependency in async.auto #1349

Merged
merged 2 commits into from Jan 9, 2017

Conversation

jahraphael
Copy link
Contributor

Hi, I'm not sure if there were specific guidelines to go through before submitting a PR, so apologies if I've missed a step. Now on to the PR:

We've been making use of async.autoInject as a light dependency injection framework, and whenever we'd make a mistake in a tasks dependencies we'd end up with a time-consuming task to track down what dependency async was failing on, because the error message wasn't giving enough to go on.

This PR simply adds the actual failed dependency to the error message to trivialize the work of tracking down missing dependencies.

@aearly
Copy link
Collaborator

aearly commented Jan 8, 2017

Can you tweak the test so it checks for the dependency name as well?

@jahraphael
Copy link
Contributor Author

Sure, no problem.

I've pushed up changes that check within the auto prevent dead-locks due to inexistant dependencies test whether the error contains the missing dependency name (/dependency `noexist`/).

@megawac
Copy link
Collaborator

megawac commented Jan 9, 2017

Thanks a bunch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants