Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore unknown extension elements #9972

Merged
merged 1 commit into from
Aug 4, 2022

Conversation

menski
Copy link
Contributor

@menski menski commented Aug 3, 2022

Description

Allow users to deploy BPMN models with unknown extension elements added by other vendors to allow round-trips and migrations.

Related issues

closes #4817

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/1.3) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • New content is added to the release announcement
  • If the PR changes how BPMN processes are validated (e.g. support new BPMN element) then the Camunda modeling team should be informed to adjust the BPMN linting.

Please refer to our review guidelines.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2022

Test Results

   804 files  ±    0     804 suites  +1   1h 36m 21s ⏱️ - 6m 28s
6 321 tests +191  6 312 ✔️ +191  9 💤 ±0  0 ±0 
6 507 runs  +191  6 498 ✔️ +191  9 💤 ±0  0 ±0 

Results for commit c3aee33. ± Comparison against base commit 0e6c55d.

♻️ This comment has been updated with latest results.

@menski menski marked this pull request as ready for review August 3, 2022 16:09
@menski menski requested a review from saig0 August 3, 2022 16:09
Allow users to deploy BPMN models with unknown extension elements added
by other vendors to allow round-trips and migrations.
@menski menski force-pushed the 4817-ignore-unknown-xml-elements branch from adfa7df to c3aee33 Compare August 3, 2022 19:04
Copy link
Member

@saig0 saig0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@menski nice 👍 Thank you for fixing the issue 🎉

@saig0
Copy link
Member

saig0 commented Aug 4, 2022

bors merge

@zeebe-bors-camunda
Copy link
Contributor

Build succeeded:

@zeebe-bors-camunda zeebe-bors-camunda bot merged commit 4bf028e into main Aug 4, 2022
@zeebe-bors-camunda zeebe-bors-camunda bot deleted the 4817-ignore-unknown-xml-elements branch August 4, 2022 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

java.lang.ClassCastException: class ModelElementInstanceImpl cannot be cast to class BpmnModelElementInstance
2 participants