Split deployment distribution behavior #9872
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pihme
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...io/camunda/zeebe/engine/processing/deployment/distribute/DeploymentPartitionDistributor.java
Fixed
Show fixed
Hide fixed
...io/camunda/zeebe/engine/processing/deployment/distribute/DeploymentPartitionDistributor.java
Fixed
Show fixed
Hide fixed
korthout
reviewed
Jul 26, 2022
There was a problem hiding this comment.
After reviewing the changes in this PR I wanted to accept it, but I did expect some conflicts with #9858. Now that #9858 is merged, it's clear that it doesn't just conflict but completely replaces the code that was extracted here. I think there's no need for this PR anymore, as the new implementation doesn't have the problem that this PR tried to fix.
@pihme I guess this review came just too late, sorry about that 🙇
|
@korthout This PR still has one purpose: to remove |
pihme
force-pushed
the
pihme-split-deployment-distribution-processor
branch
from
e2bc6bd
to
d2709ca
Compare
|
Closing this PR as its description is obsolete. PR will be recreated with updated description |
zeebe-bors-camunda bot
added a commit
that referenced
this pull request
Aug 3, 2022
9967: Remove writers from interface r=pihme a=pihme ## Description This PR removes the writers fronm `ReadOnlyStreamProcessorContext`. This is important, because the writers are an engine-internal construct, only valid during calls to `process(...)` or `onError(...)` and must not be handed out to other classes. ## Related issues relates to #9725 replaces #9872 Co-authored-by: pihme <pihme@users.noreply.github.com>
zeebe-bors-camunda bot
added a commit
that referenced
this pull request
Aug 4, 2022
9967: Remove writers from interface r=pihme a=pihme ## Description This PR removes the writers fronm `ReadOnlyStreamProcessorContext`. This is important, because the writers are an engine-internal construct, only valid during calls to `process(...)` or `onError(...)` and must not be handed out to other classes. ## Related issues relates to #9725 replaces #9872 Co-authored-by: pihme <pihme@users.noreply.github.com>
zeebe-bors-camunda
bot
deleted the
pihme-split-deployment-distribution-processor
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Splits the
DeploymentDistributionBehaviorinto two classes. Splitting it reduces dependencies for one sub-class. This allows to remove dependency toWritersinReadOnlyStreamProcesorContextRelated issues
relates to #9725
Review hints
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/1.3) to the PR, in case that fails you need to create backports manually.Testing:
Documentation:
Please refer to our review guidelines.