Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move stream processor classes into the stream processor package #9852

Merged
merged 3 commits into from
Jul 22, 2022
Merged

Move stream processor classes into the stream processor package #9852

merged 3 commits into from
Jul 22, 2022

Conversation

pihme
Copy link
Contributor

@pihme pihme commented Jul 21, 2022 •
edited

Description

  • Move classes that are only used by stream processor into the corresponding package
  • There were no other changes apart from moving the classes

Related issues

related to #9725

Merge only after #9853 (this PR can easily be regenerated; the other one cannot)

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/1.3) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • New content is added to the release announcement
  • If the PR changes how BPMN processes are validated (e.g. support new BPMN element) then the Camunda modeling team should be informed to adjust the BPMN linting.

Please refer to our review guidelines.

@pihme pihme requested a review from npepinpe July 21, 2022 08:58
@pihme pihme changed the title 9725 move classes Move stream processor classes into the stream processor package Jul 21, 2022
@github-actions
Copy link
Contributor

Unit Test Results

   792 files  ±    0     792 suites  ±0   1h 35m 39s ⏱️ - 3m 7s
6 119 tests +264  6 110 ✔️ +264  9 💤 ±0  0 ❌ ±0 
6 288 runs  +264  6 279 ✔️ +264  9 💤 ±0  0 ❌ ±0 

Results for commit 385d9de. ± Comparison against base commit bbbb0d3.

@pihme pihme requested review from remcowesterhoud and removed request for remcowesterhoud July 21, 2022 11:30
npepinpe
npepinpe approved these changes Jul 21, 2022
View reviewed changes
Copy link
Member

@npepinpe npepinpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

bors merge

@pihme
Copy link
Contributor Author

pihme commented Jul 21, 2022

bors cancel

@zeebe-bors-camunda
Copy link
Contributor

Canceled.

@pihme
Copy link
Contributor Author

pihme commented Jul 21, 2022

Merge only after #9853 (this PR can easily be regenerated; the other one cannot)

@npepinpe
Copy link
Member

Sorry, I missed that 🙈

@pihme
Copy link
Contributor Author

pihme commented Jul 22, 2022

bors merge

@zeebe-bors-camunda
Copy link
Contributor

Build succeeded:

@zeebe-bors-camunda zeebe-bors-camunda bot merged commit 6089f84 into main Jul 22, 2022
@zeebe-bors-camunda zeebe-bors-camunda bot deleted the 9725-move-classes branch July 22, 2022 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npepinpe npepinpe npepinpe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pihme @npepinpe