Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shape legacy code into new interfaces part 3 (code cleanup) #9846

Merged
merged 2 commits into from
Jul 21, 2022
Merged

Shape legacy code into new interfaces part 3 (code cleanup) #9846

merged 2 commits into from
Jul 21, 2022

Conversation

pihme
Copy link
Contributor

@pihme pihme commented Jul 20, 2022

Description

Some code cleanup before the next steps.

Related issues

related to #9725

Definition of Done

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/1.3) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • New content is added to the release announcement
  • If the PR changes how BPMN processes are validated (e.g. support new BPMN element) then the Camunda modeling team should be informed to adjust the BPMN linting.

Please refer to our review guidelines.

@pihme
refactor(engine): simplify code
e511448
@pihme
refactor(engine): make context a type parameter
103a7d6 
This way, each implementation of RecordProcessor can provide their
own context object.

This is part of the preparation for BackupRecordProcessor
@pihme pihme requested a review from npepinpe July 20, 2022 12:25
@github-actions
Copy link
Contributor

github-actions bot commented Jul 20, 2022 •
edited

Unit Test Results

   792 files  ±  0     792 suites  ±0   1h 36m 49s ⏱️ - 1m 57s
5 927 tests +72  5 918 ✔️ +72  9 💤 ±0  0 ❌ ±0 
6 096 runs  +72  6 087 ✔️ +72  9 💤 ±0  0 ❌ ±0 

Results for commit 103a7d6. ± Comparison against base commit bbbb0d3.

♻️ This comment has been updated with latest results.

npepinpe
npepinpe approved these changes Jul 21, 2022
View reviewed changes
Copy link
Member

@npepinpe npepinpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

bors merge

@zeebe-bors-camunda
Copy link
Contributor

Build succeeded:

@zeebe-bors-camunda zeebe-bors-camunda bot merged commit 358dc73 into main Jul 21, 2022
@zeebe-bors-camunda zeebe-bors-camunda bot deleted the 9725-shape-legacy-code-into-new-interfaces-part-3 branch July 21, 2022 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npepinpe npepinpe npepinpe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pihme @npepinpe