[Backport stable/8.0] Reject duplicate parallel gateway activate command #9823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parallel gateways get activated by taking a sequence flow and checking if the number of taken flows is greater or equal to the number of incoming sequence flows. If this is the case an activate command is sent. The number of taken sequence flows get rest upon activation of the parallel gateway. This proves troublesome when a "bad" model causes one of the incoming sequence flows to be taken twice. This could result in the activation command being sent twice. Imagine there is a parallel gateway with 2 incoming flows. What would happen is: 1. First flow is taken 2. Second flow is taken. Incoming flows == taken flows so an activate command is sent. 3. Second flow is taken again. The first activate command has not been processed yet. The number of taken flows has not been reset. As a result incoming flows < taken flows. A second activate command is sent. (cherry picked from commit a14ce8c)
10 tasks
This check has been moved to the ProcessInstanceStateTransitionGuard. We can always send the activate command. If a parallel gateway cannot be activated the command gets rejected. This might have a small impact on performance, as now we are sending commands and rejecting them, as opposed to not sending the commands at all. (cherry picked from commit 016c280)
(cherry picked from commit 1f5a1dd)
Expand the test to also assert that we reject the command twice, and only activate it once. (cherry picked from commit aa9fab1)
remcowesterhoud
force-pushed
the
backport-9759-to-stable/8.0
branch
from
ef730ad
to
27c70d5
Compare
|
Build failed: |
|
bors retry |
|
Build failed: |
|
bors retry |
|
Build failed: |
|
Come on bors ... bors retry |
|
docker hub is having issues https://status.docker.com/pages/history/533c6539221ae15e3f000031 |
|
I figured it would be something like this. I'll try again later. Thanks 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #9759 to
stable/8.0.relates to #6778