Move LastProcessedPositionState to stream processor
#9801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The last processed position state is only used by the StreamProcessor. Therefore, it was moved into the streamprocessor package. The existing classes and interfaces were moved as is. There is probably a way to simplify this code, but this is something we can still do after the refactoring. In the tests, minimal effort was undertaken to make the tests pass. The test classes are very complex and ripe for an overhaul, but this would have increased the change set considerably
|
/cc @deepthidevaki relates to the discussion we had about separating the DB state between engine and non-engine |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| streamProcessorDbState = new StreamProcessorDbState(zeebeDb, transactionContext); | ||
| streamProcessorContext.lastProcessedPositionState( | ||
| getStreamProcessorDbState().getLastProcessedPositionState()); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation
| return factory.createProcessors(processingContext); | ||
| })); | ||
|
|
||
| lastProcessedPositionState = result.getStreamProcessorDbState().getLastProcessedPositionState(); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation
| return factory.createProcessors(processingContext); | ||
| })); | ||
|
|
||
| lastProcessedPositionState = result.getStreamProcessorDbState().getLastProcessedPositionState(); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation
| }), | ||
| streamWriterFactory); | ||
|
|
||
| lastProcessedPositionState = result.getStreamProcessorDbState().getLastProcessedPositionState(); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation
npepinpe
approved these changes
Jul 14, 2022
engine/src/main/java/io/camunda/zeebe/streamprocessor/StreamProcessor.java
Show resolved
Hide resolved
|
bors merge |
zeebe-bors-camunda bot
added a commit
that referenced
this pull request
Jul 18, 2022
9801: Move `LastProcessedPositionState` to stream processor r=pihme a=pihme ## Description The last processed position state is only used by the StreamProcessor. Therefore, it was moved into the streamprocessor package. The existing classes and interfaces were moved as is. There is probably a way to simplify this code, but this is something we can still do after the refactoring. In the tests, minimal effort was undertaken to make the tests pass. The test classes are very complex and ripe for an overhaul, but this would have increased the change set considerably. ## Related issues related to #9725 Co-authored-by: pihme <pihme@users.noreply.github.com>
|
Build failed: |
|
bors retry |
|
Build succeeded: |
zeebe-bors-camunda
bot
deleted the
9725-move-last-processed-position-db-state-to-stream-processor
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The last processed position state is only used by the StreamProcessor. Therefore, it
was moved into the streamprocessor package. The existing classes and interfaces were
moved as is. There is probably a way to simplify this code, but this is something we
can still do after the refactoring.
In the tests, minimal effort was undertaken to make the tests pass. The test classes
are very complex and ripe for an overhaul, but this would have increased the change
set considerably.
Related issues
related to #9725
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/1.3) to the PR, in case that fails you need to create backports manually.Testing:
Documentation:
Please refer to our review guidelines.