Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move TypedRecord to api #9744

Merged
merged 3 commits into from
Jul 8, 2022
Merged

Conversation

pihme
Copy link
Contributor

@pihme pihme commented Jul 8, 2022

Description

Moves TypedRecord to api package

Related issues

related to #9725

Definition of Done

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/1.3) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • New content is added to the release announcement
  • If the PR changes how BPMN processes are validated (e.g. support new BPMN element) then the Camunda modeling team should be informed to adjust the BPMN linting.

Please refer to our review guidelines.

@pihme pihme requested a review from npepinpe July 8, 2022 11:22
@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2022

Unit Test Results

   789 files  ±  0     789 suites  ±0   1h 42m 4s ⏱️ + 2m 26s
6 133 tests +97  6 126 ✔️ +97  7 💤 ±0  0 ±0 
6 302 runs  +97  6 295 ✔️ +97  7 💤 ±0  0 ±0 

Results for commit a3b3340. ± Comparison against base commit b4122ff.

♻️ This comment has been updated with latest results.

Copy link
Member

@npepinpe npepinpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • 💭 Out of scope, but I wonder why we override getKey() and getValue() in TypedRecord? 🤷

@pihme pihme force-pushed the 9725-move-typedrecord-to-api branch from 31ff968 to a3b3340 Compare July 8, 2022 13:18
@pihme
Copy link
Contributor Author

pihme commented Jul 8, 2022

bors merge

@zeebe-bors-camunda
Copy link
Contributor

Build succeeded:

@zeebe-bors-camunda zeebe-bors-camunda bot merged commit cb99933 into main Jul 8, 2022
@zeebe-bors-camunda zeebe-bors-camunda bot deleted the 9725-move-typedrecord-to-api branch July 8, 2022 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants