Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark in processing via flag #9741

Merged
merged 1 commit into from
Jul 8, 2022
Merged

Conversation

Zelldon
Copy link
Member

@Zelldon Zelldon commented Jul 8, 2022

Description

Previously the processing has been marked implicit via the currentProcessor
in order to move the processing call out to the engine, we need to mark
the processing more explicit.

Related issues

as preparation for #9725

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/1.3) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • New content is added to the release announcement
  • If the PR changes how BPMN processes are validated (e.g. support new BPMN element) then the Camunda modeling team should be informed to adjust the BPMN linting.

Please refer to our review guidelines.

@Zelldon Zelldon requested a review from pihme July 8, 2022 07:20
@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2022

Unit Test Results

   747 files   -   41     747 suites   - 41   24m 48s ⏱️ - 1h 13m 3s
5 913 tests  - 169  5 905 ✔️  - 170  8 💤 +1  0 ±0 
6 080 runs   - 171  6 072 ✔️  - 172  8 💤 +1  0 ±0 

Results for commit c9e84da. ± Comparison against base commit 0fcf857.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@pihme pihme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ I am still wondering whether this can work. I can see that it works for the happy path, i.e. no exception. I don't see how it works in case an exception happens. At the same time, I also don't understand how it would work with the code before. So maybe this is how it is supposed to work? I.e. any exception will stop the acor?

If you have more background for this question, please share with me.

@Zelldon
Copy link
Member Author

Zelldon commented Jul 8, 2022

Exceptions in processing are catched here https://github.com/camunda/zeebe/blob/main/engine/src/main/java/io/camunda/zeebe/engine/processing/streamprocessor/ProcessingStateMachine.java#L259-L271

And we always follow this state machine https://github.com/camunda/zeebe/blob/main/engine/src/main/java/io/camunda/zeebe/engine/processing/streamprocessor/ProcessingStateMachine.java#L45-L76 where at some point we reach the execute side effects again and reset the flag.

Previously the processing has been marked implicit via the currentProcessor
in order to move the processing call out to the engine we need to mark
the processing more explicit.
@pihme
Copy link
Contributor

pihme commented Jul 8, 2022

@Zelldon Already rebased it.

@Zelldon
Copy link
Member Author

Zelldon commented Jul 8, 2022

Oh great thanks @pihme

@Zelldon
Copy link
Member Author

Zelldon commented Jul 8, 2022

bors r+

zeebe-bors-camunda bot added a commit that referenced this pull request Jul 8, 2022
9741: Mark in processing via flag r=Zelldon a=Zelldon

## Description

Previously the processing has been marked implicit via the currentProcessor
in order to move the processing call out to the engine, we need to mark
the processing more explicit.

<!-- Please explain the changes you made here. -->

## Related issues

<!-- Which issues are closed by this PR or are related -->

as preparation for #9725 



Co-authored-by: Christopher Zell <zelldon91@googlemail.com>
@zeebe-bors-camunda
Copy link
Contributor

Build failed:

@pihme
Copy link
Contributor

pihme commented Jul 8, 2022

bors retry

@zeebe-bors-camunda
Copy link
Contributor

Build succeeded:

@zeebe-bors-camunda zeebe-bors-camunda bot merged commit c0cf068 into main Jul 8, 2022
@zeebe-bors-camunda zeebe-bors-camunda bot deleted the zell-mark-processing branch July 8, 2022 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants