-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark in processing via flag #9741
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ I am still wondering whether this can work. I can see that it works for the happy path, i.e. no exception. I don't see how it works in case an exception happens. At the same time, I also don't understand how it would work with the code before. So maybe this is how it is supposed to work? I.e. any exception will stop the acor?
If you have more background for this question, please share with me.
Exceptions in processing are catched here https://github.com/camunda/zeebe/blob/main/engine/src/main/java/io/camunda/zeebe/engine/processing/streamprocessor/ProcessingStateMachine.java#L259-L271 And we always follow this state machine https://github.com/camunda/zeebe/blob/main/engine/src/main/java/io/camunda/zeebe/engine/processing/streamprocessor/ProcessingStateMachine.java#L45-L76 where at some point we reach the execute side effects again and reset the flag. |
Previously the processing has been marked implicit via the currentProcessor in order to move the processing call out to the engine we need to mark the processing more explicit.
3b76289
to
c9e84da
Compare
@Zelldon Already rebased it. |
Oh great thanks @pihme |
bors r+ |
9741: Mark in processing via flag r=Zelldon a=Zelldon ## Description Previously the processing has been marked implicit via the currentProcessor in order to move the processing call out to the engine, we need to mark the processing more explicit. <!-- Please explain the changes you made here. --> ## Related issues <!-- Which issues are closed by this PR or are related --> as preparation for #9725 Co-authored-by: Christopher Zell <zelldon91@googlemail.com>
Build failed: |
bors retry |
Build succeeded: |
Description
Previously the processing has been marked implicit via the currentProcessor
in order to move the processing call out to the engine, we need to mark
the processing more explicit.
Related issues
as preparation for #9725
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/1.3
) to the PR, in case that fails you need to create backports manually.Testing:
Documentation:
Please refer to our review guidelines.