Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport stable/8.0] Escalate errors in output mapping evaluation #9696

Merged
merged 3 commits into from
Jul 5, 2022
Merged

[Backport stable/8.0] Escalate errors in output mapping evaluation #9696

merged 3 commits into from
Jul 5, 2022

Conversation

backport-action
Copy link
Collaborator

Description

Backport of #9668 to stable/8.0.

relates to #9543

pihme added 3 commits July 5, 2022 10:28
@pihme @github-actions
test(engine): refactor test to Junit 5
a42f030 
(cherry picked from commit 401eb34)
@pihme @github-actions
fix(engine): propagate evaluation error
bec7ba2 
(cherry picked from commit daa346d)
@pihme @github-actions
refactor(engine): flip logic in expression
7ee00a5 
The expression will appear in the failure message of the evaluation.

(cherry picked from commit da446e7)
@backport-action backport-action mentioned this pull request Jul 5, 2022
Merged
10 tasks
@pihme pihme self-requested a review July 5, 2022 10:52
pihme
pihme approved these changes Jul 5, 2022
View reviewed changes
Copy link
Contributor

@pihme pihme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approve backported PR

@pihme
Copy link
Contributor

pihme commented Jul 5, 2022

bors merge

zeebe-bors-camunda bot added a commit that referenced this pull request Jul 5, 2022
@zeebe-bors-camunda @pihme
merge: #9696
6a4ccce 
9696: [Backport stable/8.0] Escalate errors in output mapping evaluation r=pihme a=backport-action

# Description
Backport of #9668 to `stable/8.0`.

relates to #9543

Co-authored-by: pihme <pihme@users.noreply.github.com>
@zeebe-bors-camunda
Copy link
Contributor

Build failed:

@pihme
Copy link
Contributor

pihme commented Jul 5, 2022

bors retry

zeebe-bors-camunda bot added a commit that referenced this pull request Jul 5, 2022
@zeebe-bors-camunda @pihme
merge: #9696
663ba9f 
9696: [Backport stable/8.0] Escalate errors in output mapping evaluation r=pihme a=backport-action

# Description
Backport of #9668 to `stable/8.0`.

relates to #9543

Co-authored-by: pihme <pihme@users.noreply.github.com>
@pihme
Copy link
Contributor

pihme commented Jul 5, 2022

bors cancel

@zeebe-bors-camunda
Copy link
Contributor

Canceled.

@pihme
Copy link
Contributor

pihme commented Jul 5, 2022

bors retry

@pihme
Copy link
Contributor

pihme commented Jul 5, 2022

bors merge

@zeebe-bors-camunda
Copy link
Contributor

Build succeeded:

@zeebe-bors-camunda zeebe-bors-camunda bot merged commit ac21469 into stable/8.0 Jul 5, 2022
@zeebe-bors-camunda zeebe-bors-camunda bot deleted the backport-9668-to-stable/8.0 branch July 5, 2022 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pihme pihme pihme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@backport-action @pihme