feat(gateway): deprecate the contactPoint property and introduce the initialContactProperties #9508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aivinog1
changed the title
aivinog1
force-pushed
the
4856_initial_contact_point_list
branch
from
65e8377
to
f006950
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| // when | ||
| final GatewayCfg gatewayCfg = | ||
| new GatewayCfg().setCluster(new ClusterCfg().setContactPoint(contactPoint)); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation
|
@Zelldon can you have a look at the PR? |
Zelldon
reviewed
Jun 22, 2022
gateway/src/main/java/io/camunda/zeebe/gateway/impl/configuration/ClusterCfg.java
Outdated
Show resolved
Hide resolved
…initialContactProperties
aivinog1
force-pushed
the
4856_initial_contact_point_list
branch
from
f006950
to
fe2200a
Compare
Co-authored-by: Christopher Zell <zelldon91@googlemail.com>
|
Hey @Zelldon! It's done :) |
Zelldon
approved these changes
Jun 27, 2022
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace the
contactPointproperty with theinitialContactPointsproperty. So, there now could be an array of broker connections on the start.Related issues
closes #4856
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/1.3) to the PR, in case that fails you need to create backports manually.Testing:
Documentation:
Please refer to our review guidelines.