Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client-go): add support for backoff timeout for failed jobs in the Go client and zbctl #9417

Merged

Conversation

aivinog1
Copy link
Contributor

Description

I've added mapping in the Go client and an additional flag that matches job backoff.

Related issues

closes #5629

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/1.3) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • New content is added to the release announcement
  • If the PR changes how BPMN processes are validated (e.g. support new BPMN element) then the Camunda modeling team should be informed to adjust the BPMN linting.

Please refer to our review guidelines.

@pihme pihme self-requested a review June 1, 2022 09:16
Copy link
Contributor

@pihme pihme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aivinog1 for your contribution! Looking forward to seeing this in action.

@pihme
Copy link
Contributor

pihme commented Jun 1, 2022

bors merge

zeebe-bors-camunda bot added a commit that referenced this pull request Jun 1, 2022
9417: feat(client-go): add support for backoff timeout for failed jobs in the Go client and zbctl r=pihme a=aivinog1

## Description

<!-- Please explain the changes you made here. -->
I've added mapping in the Go client and an additional flag that matches job backoff.

## Related issues

<!-- Which issues are closed by this PR or are related -->

closes #5629 



Co-authored-by: Alexey Vinogradov <vinogradov.a.i.93@gmail.com>
@zeebe-bors-camunda
Copy link
Contributor

Build failed:

@aivinog1
Copy link
Contributor Author

aivinog1 commented Jun 1, 2022

@pihme Hey, maybe you have some insights into why the build failed? :)

@pihme
Copy link
Contributor

pihme commented Jun 1, 2022

@aivinog1 Yes, I do. The build failed because of an interface compatibility check which detected the change.
I am currently investigating internally how to reset the compatibility check after the change. Might take a bit. I am not too familiar with the Go code and this part of the build pipeline, so a bit slow.

@pihme
Copy link
Contributor

pihme commented Jun 2, 2022

@aivinog1 Hope you don't mind that I simply added a commit, instead of forking your fork :-)

If you want to replicate the step, all that is needed is to run cd clients/go && gocompat save ./...

@pihme
Copy link
Contributor

pihme commented Jun 2, 2022

bors retry

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2022

Unit Test Results

   795 files     795 suites   1h 35m 32s ⏱️
5 525 tests 5 520 ✔️ 5 💤 0
5 689 runs  5 684 ✔️ 5 💤 0

Results for commit e5d7f34.

@zeebe-bors-camunda
Copy link
Contributor

Build succeeded:

@zeebe-bors-camunda zeebe-bors-camunda bot merged commit 3ff54bf into camunda:main Jun 2, 2022
@aivinog1 aivinog1 deleted the 5629-client-go-backoff-timeout branch June 2, 2022 07:40
@aivinog1
Copy link
Contributor Author

aivinog1 commented Jun 2, 2022

Thanks @pihme :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clients can set an optional backoff time to the failed tasks.
2 participants