-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(client-go): add support for backoff timeout for failed jobs in the Go client and zbctl #9417
feat(client-go): add support for backoff timeout for failed jobs in the Go client and zbctl #9417
Conversation
…he Go client and zbctl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @aivinog1 for your contribution! Looking forward to seeing this in action.
bors merge |
9417: feat(client-go): add support for backoff timeout for failed jobs in the Go client and zbctl r=pihme a=aivinog1 ## Description <!-- Please explain the changes you made here. --> I've added mapping in the Go client and an additional flag that matches job backoff. ## Related issues <!-- Which issues are closed by this PR or are related --> closes #5629 Co-authored-by: Alexey Vinogradov <vinogradov.a.i.93@gmail.com>
Build failed: |
@pihme Hey, maybe you have some insights into why the build failed? :) |
@aivinog1 Yes, I do. The build failed because of an interface compatibility check which detected the change. |
@aivinog1 Hope you don't mind that I simply added a commit, instead of forking your fork :-) If you want to replicate the step, all that is needed is to run |
bors retry |
Build succeeded: |
Thanks @pihme :) |
Description
I've added mapping in the Go client and an additional flag that matches job backoff.
Related issues
closes #5629
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/1.3
) to the PR, in case that fails you need to create backports manually.Testing:
Documentation:
Please refer to our review guidelines.