Add actor metrics #9294
Merged
Add actor metrics #9294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add counter for actorTask execution Add histogram to observe actorTask execution
|
Seems to work. Example panels people could create
|
npepinpe
approved these changes
May 5, 2022
| import io.prometheus.client.Counter; | ||
| import io.prometheus.client.Histogram; | ||
|
|
||
| public class ActorMetrics { |
There was a problem hiding this comment.
Suggested change
| public class ActorMetrics { | |
| final class ActorMetrics { |
There was a problem hiding this comment.
🔧 As a rule of thumb, I would generally keep the lowest visibility required if only to make sure when other classes depend on one (i.e. it must be made public) hopefully we think about it and what it means to couple them.
There was a problem hiding this comment.
I guess I shouldn't just copy old branches 😅 BTW why we still have no check for class needs to be final ? 🤔 I guess it is not easy to detect ? 🤔 Or what is the reason?
util/src/main/java/io/camunda/zeebe/util/sched/ActorMetrics.java
Outdated
Show resolved
Hide resolved
util/src/main/java/io/camunda/zeebe/util/sched/ActorMetrics.java
Outdated
Show resolved
Hide resolved
util/src/main/java/io/camunda/zeebe/util/sched/ActorThread.java
Outdated
Show resolved
Hide resolved
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discussed here https://camunda.slack.com/archives/C037RS2JHB8/p1651668160788749 add new actor metrics but no new panels for now.
Details:
Currently starting a benchmark to verify whether metrics are exported as expected.
I will create a separate PR for the atomix executors.
@npepinpe I'm not sure whether it fulfills all requirements for #9282 I will remove my assignment then.
Related issues
related #9282
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/1.3) to the PR, in case that fails you need to create backports manually.Testing:
Documentation:
Please refer to our review guidelines.