-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 1.3] Trigger boundary events only if the flow scope is active #9293
Merged
zeebe-bors-camunda
merged 5 commits into
stable/1.3
from
9233-terminate-call-activity-backport-1.3
May 5, 2022
Merged
[Backport 1.3] Trigger boundary events only if the flow scope is active #9293
zeebe-bors-camunda
merged 5 commits into
stable/1.3
from
9233-terminate-call-activity-backport-1.3
May 5, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bors merge |
👎 Rejected by too few approved reviews |
korthout
approved these changes
May 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ☕
bors merge |
zeebe-bors-camunda bot
added a commit
that referenced
this pull request
May 5, 2022
9293: [Backport 1.3] Trigger boundary events only if the flow scope is active r=saig0 a=saig0 ## Description Backport of #9281 Only one additional change compared to the origin PR for downgrading the test code to Java 11. ## Related issues relates to #9233 Co-authored-by: Philipp Ossler <philipp.ossler@gmail.com>
Build failed: |
bors merge |
zeebe-bors-camunda bot
added a commit
that referenced
this pull request
May 5, 2022
9293: [Backport 1.3] Trigger boundary events only if the flow scope is active r=saig0 a=saig0 ## Description Backport of #9281 Only one additional change compared to the origin PR for downgrading the test code to Java 11. ## Related issues relates to #9233 Co-authored-by: Philipp Ossler <philipp.ossler@gmail.com>
Build failed: |
bors merge |
zeebe-bors-camunda bot
added a commit
that referenced
this pull request
May 5, 2022
9293: [Backport 1.3] Trigger boundary events only if the flow scope is active r=saig0 a=saig0 ## Description Backport of #9281 Only one additional change compared to the origin PR for downgrading the test code to Java 11. ## Related issues relates to #9233 Co-authored-by: Philipp Ossler <philipp.ossler@gmail.com>
Build failed: |
bors merge |
zeebe-bors-camunda bot
added a commit
that referenced
this pull request
May 5, 2022
9293: [Backport 1.3] Trigger boundary events only if the flow scope is active r=saig0 a=saig0 ## Description Backport of #9281 Only one additional change compared to the origin PR for downgrading the test code to Java 11. ## Related issues relates to #9233 Co-authored-by: Philipp Ossler <philipp.ossler@gmail.com>
Build failed: |
bors merge |
zeebe-bors-camunda bot
added a commit
that referenced
this pull request
May 5, 2022
9293: [Backport 1.3] Trigger boundary events only if the flow scope is active r=saig0 a=saig0 ## Description Backport of #9281 Only one additional change compared to the origin PR for downgrading the test code to Java 11. ## Related issues relates to #9233 Co-authored-by: Philipp Ossler <philipp.ossler@gmail.com>
Build failed: |
(cherry picked from commit ef7a813)
* verify that a boundary event is not activated if the flow scope is terminating (cherry picked from commit 30d0700)
* replace the boundary test for service tasks by a parameterized test for all relevant BPMN elements (cherry picked from commit 0df9328)
* check if the flow scope is active before activating a boundary event * align the termination logic for the BPMN element processors (cherry picked from commit d9e82d8)
saig0
force-pushed
the
9233-terminate-call-activity-backport-1.3
branch
from
May 5, 2022 13:12
8a849dd
to
2a5f49f
Compare
bors merge |
zeebe-bors-camunda
bot
deleted the
9233-terminate-call-activity-backport-1.3
branch
May 5, 2022 13:38
Finally merged 🎉 I just needed 6 tries 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #9281
Only one additional change compared to the origin PR for downgrading the test code to Java 11.
Related issues
relates to #9233