Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 8.0] Trigger boundary events only if the flow scope is active #9292

Merged
merged 4 commits into from
May 5, 2022
Merged

[Backport 8.0] Trigger boundary events only if the flow scope is active #9292

merged 4 commits into from
May 5, 2022

Conversation

saig0
Copy link
Member

@saig0 saig0 commented May 5, 2022

Description

Backport of #9281

No additional changes compared to the origin PR.

Related issues

relates to #9233

saig0 added 4 commits May 5, 2022 07:11
@saig0
test(engine): verify trigger boundary event on call activity
212ab0e 
(cherry picked from commit ef7a813)
@saig0
test(engine): verify trigger boundary event for termination
b890c97 
* verify that a boundary event is not activated if the flow scope is terminating

(cherry picked from commit 30d0700)
@saig0
test(engine): extract boundary event test for termination
393ed3e 
* replace the boundary test for service tasks by a parameterized test for all relevant BPMN elements

(cherry picked from commit 0df9328)
@saig0
fix(engine): don't trigger boundary event is scope is not active
06a2656 
* check if the flow scope is active before activating a boundary event
* align the termination logic for the BPMN element processors

(cherry picked from commit d9e82d8)
@saig0 saig0 requested a review from korthout May 5, 2022 05:45
korthout
korthout approved these changes May 5, 2022
View reviewed changes
Copy link
Member

@korthout korthout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤖

@saig0
Copy link
Member Author

saig0 commented May 5, 2022

bors merge

zeebe-bors-camunda bot added a commit that referenced this pull request May 5, 2022
@zeebe-bors-camunda @saig0
merge: #9292
9276995 
9292: [Backport 8.0] Trigger boundary events only if the flow scope is active r=saig0 a=saig0

## Description

Backport of #9281

No additional changes compared to the origin PR.

## Related issues

relates to #9233


Co-authored-by: Philipp Ossler <philipp.ossler@gmail.com>
@zeebe-bors-camunda
Copy link
Contributor

Build failed:

@saig0
Copy link
Member Author

saig0 commented May 5, 2022

bors merge

@zeebe-bors-camunda
Copy link
Contributor

Build succeeded:

@zeebe-bors-camunda zeebe-bors-camunda bot merged commit 2f2ff34 into stable/8.0 May 5, 2022
@zeebe-bors-camunda zeebe-bors-camunda bot deleted the 9233-terminate-call-activity-backport-8.0 branch May 5, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korthout korthout korthout approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@saig0 @korthout