Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 1.3] Trigger boundary events after an interrupting event subprocess is triggered #9242

Merged
merged 11 commits into from
Apr 28, 2022

Conversation

saig0
Copy link
Member

@saig0 saig0 commented Apr 28, 2022

Description

Backport of #9175

Related issues

relates to #6874

saig0 added 11 commits April 28, 2022 07:13
* if an interrupting event subprocess is triggered then remove the subscriptions of other event subprocesses in the same flow scope
* but don't remove the subscriptions of boundary events that are attached to the scope
* the boundary events can be still triggered because they are attached to the scope and are not inside of it

(cherry picked from commit 7c76eeb)
* remove methods from event scope instance state that are only used in tests but not in production code
* these methods were used previously but are not needed anymore

(cherry picked from commit 17a66f6)
* migrate the test case from JUnit 4 to JUnit 5 using the Zeebe state extension

(cherry picked from commit 2851144)
* handle interrupting event subprocesses and interrupting boundary events differently by introducing boundary element ids
* an interrupting event subprocess interrupts the event scope, but it can still be triggered by boundary events
* after an interrupting boundary event is triggered, no other event can be triggered for the event scope

(cherry picked from commit 07cca46)
@saig0
Copy link
Member Author

saig0 commented Apr 28, 2022

@pihme please accept the PR 😅 It is a pure backport of the original PR, expect one small change (last commit) to make it compatible with Java 11.

@saig0 saig0 requested a review from pihme April 28, 2022 08:54
Copy link
Contributor

@pihme pihme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

zeebe-bors-camunda bot added a commit that referenced this pull request Apr 28, 2022
9242: [Backport 1.3] Trigger boundary events after an interrupting event subprocess is triggered r=pihme a=saig0

## Description

Backport of #9175

## Related issues

relates to #6874


Co-authored-by: Philipp Ossler <philipp.ossler@gmail.com>
@zeebe-bors-camunda
Copy link
Contributor

Build failed:

@saig0
Copy link
Member Author

saig0 commented Apr 28, 2022

bors merge

@zeebe-bors-camunda zeebe-bors-camunda bot merged commit f8434d6 into stable/1.3 Apr 28, 2022
@zeebe-bors-camunda zeebe-bors-camunda bot deleted the 6874-boundary-event_1_3 branch April 28, 2022 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants