Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for message names being null during validation #9164

Merged
merged 3 commits into from
Apr 21, 2022
Merged

Check for message names being null during validation #9164

merged 3 commits into from
Apr 21, 2022

Conversation

pihme
Copy link
Contributor

@pihme pihme commented Apr 19, 2022

Description

  • Adds a test that a validation error is generated if the message name is null
  • Adds validation logic for message name being null

Related issues

closes #9083

Definition of Done

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/1.3) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • New content is added to the release announcement
  • If the PR changes how BPMN processes are validated (e.g. support new BPMN element) then the Camunda modeling team should be informed to adjust the BPMN linting.

@pihme pihme requested a review from saig0 April 19, 2022 08:57
saig0
saig0 reviewed Apr 20, 2022
View reviewed changes
Copy link
Member

@saig0 saig0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pihme looks good in general 👍

But I'm unsure about the rejection message. I have the feeling that we will mention the same validation twice. Please check my comment.

@pihme pihme requested a review from saig0 April 20, 2022 13:34
saig0
saig0 approved these changes Apr 21, 2022
View reviewed changes
Copy link
Member

@saig0 saig0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pihme LGTM 🚀

@pihme
Copy link
Contributor Author

pihme commented Apr 21, 2022

bors merge

@zeebe-bors-camunda
Copy link
Contributor

Build succeeded:

@zeebe-bors-camunda zeebe-bors-camunda bot merged commit acf67e3 into main Apr 21, 2022
@zeebe-bors-camunda zeebe-bors-camunda bot deleted the 9083-fix branch April 21, 2022 11:44
@github-actions github-actions bot mentioned this pull request Apr 21, 2022
Merged
@github-actions
Copy link
Contributor

Successfully created backport PR #9192 for stable/1.3.

@github-actions github-actions bot mentioned this pull request Apr 21, 2022
Merged
@github-actions
Copy link
Contributor

Successfully created backport PR #9193 for stable/8.0.

zeebe-bors-camunda bot added a commit that referenced this pull request Apr 21, 2022
@zeebe-bors-camunda @pihme
merge: #9193
85bd4b3 
9193: [Backport stable/8.0] Check for message names being null during validation r=pihme a=github-actions[bot]

# Description
Backport of #9164 to `stable/8.0`.

relates to #9083

Co-authored-by: pihme <pihme@users.noreply.github.com>
zeebe-bors-camunda bot added a commit that referenced this pull request Apr 21, 2022
@zeebe-bors-camunda @pihme
merge: #9192
41c47be 
9192: [Backport stable/1.3] Check for message names being null during validation r=pihme a=github-actions[bot]

# Description
Backport of #9164 to `stable/1.3`.

relates to #9083

Co-authored-by: pihme <pihme@users.noreply.github.com>
zeebe-bors-camunda bot added a commit that referenced this pull request Apr 21, 2022
@zeebe-bors-camunda @pihme
merge: #9192
f226695 
9192: [Backport stable/1.3] Check for message names being null during validation r=pihme a=github-actions[bot]

# Description
Backport of #9164 to `stable/1.3`.

relates to #9083

Co-authored-by: pihme <pihme@users.noreply.github.com>
zeebe-bors-camunda bot added a commit that referenced this pull request Apr 21, 2022
@zeebe-bors-camunda @pihme
merge: #9192
fbd20e8 
9192: [Backport stable/1.3] Check for message names being null during validation r=pihme a=github-actions[bot]

# Description
Backport of #9164 to `stable/1.3`.

relates to #9083

Co-authored-by: pihme <pihme@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saig0 saig0 saig0 approved these changes

Assignees
No one assigned
Labels
version:1.3.8
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NPE in Validator
3 participants
@pihme @saig0 @npepinpe