[Backport stable/1.3] fix: notify new SnapshotReplicationListeners about missed replications
#8854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
We are using `SnapshotReplicationListener`s to transition to inactive when a snapshot replication starts. Snapshot replication can start before any listeners have registered, which means that the listener will only be notified about snapshot replication finishing, triggering a transition to follower without first transitioning to inactive. Here we are keeping track of ongoing snapshot replication to immediately notify listeners when they are registering. (cherry picked from commit 3d1f6c5)
(cherry picked from commit be9f78f)
Previously, we only notified new listeners about ongoing replication. This was not enough in cases where snapshot replication finished before the listener completed. (cherry picked from commit 47badee)
ghost
pushed a commit
that referenced
this pull request
Feb 28, 2022
this language feature is not available in 1.3
|
Canceled. |
|
bors r+ |
ghost
pushed a commit
that referenced
this pull request
Feb 28, 2022
|
Build failed: |
|
bors retry |
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #8834 to
stable/1.3.relates to #8830