Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unreachable code #18469

Merged
merged 1 commit into from
May 14, 2024
Merged

Remove unreachable code #18469

merged 1 commit into from
May 14, 2024

Conversation

npepinpe
Copy link
Member

Description

Removes an unnecessary condition to exit early if the record is not event. This is unnecessary because we're already applying a record filter for the exporter which only accepts events.

Related issues

closes #9760

Removes an unnecessary condition to exit early if the record is not
event. This is unnecessary because we're already applying a record
filter for the exporter which only accepts events.
@github-actions github-actions bot added the component/zeebe Related to the Zeebe component/team label May 13, 2024
@npepinpe npepinpe self-assigned this May 13, 2024
Copy link
Contributor

@rodrigo-lourenco-lopes rodrigo-lourenco-lopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks for the changes!

@npepinpe npepinpe added this pull request to the merge queue May 14, 2024
Merged via the queue into main with commit 70b6485 May 14, 2024
37 checks passed
@npepinpe npepinpe deleted the np-9760-remove-dead-code branch May 14, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/zeebe Related to the Zeebe component/team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dead code in metrics exporter
2 participants