Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Opensearch metafield update methods #18458

Merged
merged 4 commits into from
May 14, 2024
Merged

fix: Opensearch metafield update methods #18458

merged 4 commits into from
May 14, 2024

Conversation

sdorokhova
Copy link
Contributor

@sdorokhova sdorokhova commented May 13, 2024 •
edited

  • implement Opensearch methods to check meta fields

closes #18452

@github-actions github-actions bot added the component/operate Related to the Operate component/team label May 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 13, 2024 •
edited

Test Results

823 tests  ±0   803 ✅ ±0   17m 56s ⏱️ + 1m 45s
138 suites ±0    20 💤 ±0 
138 files   ±0     0 ❌ ±0 

Results for commit d663da4. ± Comparison against base commit 4c05abb.

♻️ This comment has been updated with latest results.

@sdorokhova sdorokhova linked an issue May 13, 2024 that may be closed by this pull request
Operate import does not work for Opensearch with UnsupportedOperationException #18452
Closed
5 tasks
@sdorokhova sdorokhova marked this pull request as ready for review May 14, 2024 09:10
@sdorokhova sdorokhova requested a review from a team May 14, 2024 09:10
@sdorokhova
Copy link
Contributor Author

sdorokhova commented May 14, 2024 •
edited

Current PR is fixing the main functionality for Opensearch, but the functionality implemented in https://github.com/camunda/operate/issues/6477 is still not fully working. Two tests are failing when run on Opensearch:

VariableZeebeRecordProcessorIT
EventZeebeRecordProcessorIT

The reason is that sometimes we have null values in script parameters, which is failing on Opensearch. E.g. FULL_VALUE in variable update query may be null: https://github.com/camunda/zeebe/blob/67bbaf1afa679e2bf1af192780c1d1519563a62b/operate/importer-8_5/src/main/java/io/camunda/operate/zeebeimport/processors/VariableZeebeRecordProcessor.java#L91
This is not crutial for now but must be fixed as preparation for Operate exporter epic.

@sdorokhova sdorokhova mentioned this pull request May 14, 2024
Open
5 tasks
johanwelgemoed
johanwelgemoed approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@johanwelgemoed johanwelgemoed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but you can decide if you prefer someone else also having a look and just ask them for review as well.

@sdorokhova sdorokhova merged commit b57e08e into stable/operate-8.5 May 14, 2024
18 of 19 checks passed
@sdorokhova sdorokhova deleted the operate-18452-opensearch-import branch May 14, 2024 14:46
@sdorokhova sdorokhova mentioned this pull request May 16, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request May 21, 2024
@kristinkomschow
fix: Opensearch metafield update methods (#18580)
a5c8391 
* implement Opensearch methods to check meta fields

closes #18452 in `main`

(This is the cherry-pick from
#18458 and
#18534)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ralfpuchert ralfpuchert ralfpuchert approved these changes

@johanwelgemoed johanwelgemoed johanwelgemoed approved these changes

@matt-whiteman matt-whiteman matt-whiteman approved these changes

Assignees
No one assigned
Labels
component/operate Related to the Operate component/team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Operate import does not work for Opensearch with UnsupportedOperationException
4 participants
@sdorokhova @ralfpuchert @johanwelgemoed @matt-whiteman