-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move user command backpressure to log stream module #18368
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleschoenburg
force-pushed
the
os/uc-flow-control
branch
2 times, most recently
from
May 8, 2024 14:29
853c2d9
to
1ee4844
Compare
The old backpressure configuration is still used.
The old backpressure config is still allowed. When the new config isn't set, we fall back to it.
oleschoenburg
force-pushed
the
os/uc-flow-control
branch
from
May 21, 2024 11:28
d0568e8
to
5c0f0bb
Compare
github-actions
bot
added
component/operate
Related to the Operate component/team
component/tasklist
Related to the Tasklist component/team
labels
May 21, 2024
oleschoenburg
force-pushed
the
os/uc-flow-control
branch
2 times, most recently
from
May 21, 2024 15:58
e3fb208
to
51ffa1e
Compare
oleschoenburg
force-pushed
the
os/uc-flow-control
branch
from
May 21, 2024 16:17
51ffa1e
to
fcf6f15
Compare
oleschoenburg
force-pushed
the
os/uc-flow-control
branch
from
May 21, 2024 16:35
f4015b7
to
8fa3247
Compare
oleschoenburg
removed
component/operate
Related to the Operate component/team
component/tasklist
Related to the Tasklist component/team
labels
May 21, 2024
rodrigo-lourenco-lopes
approved these changes
May 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes 🚀 🚀 Just take a look at the suggestions before merging if they make sense.
zeebe/logstreams/src/main/java/io/camunda/zeebe/logstreams/impl/log/LogStreamImpl.java
Outdated
Show resolved
Hide resolved
zeebe/logstreams/src/main/java/io/camunda/zeebe/logstreams/impl/flowcontrol/FlowControl.java
Show resolved
Hide resolved
github-actions
bot
added
component/operate
Related to the Operate component/team
component/tasklist
Related to the Tasklist component/team
labels
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component/operate
Related to the Operate component/team
component/tasklist
Related to the Tasklist component/team
component/zeebe
Related to the Zeebe component/team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
User command backpressure used to be implemented in
CommandApiRequestHandler
. This PR moves it to the log stream module.Backpressure is still configurable via
zeebe.broker.backpressure
butzeebe.broker.flowControl
takes precedence.Related issues
closes #18120