Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: start Camunda as one application #18193

Merged
merged 2 commits into from
May 16, 2024
Merged

Conversation

romansmirnov
Copy link
Member

@romansmirnov romansmirnov commented May 2, 2024

Description

With this Pull Request, a Single Application (containing Operate and Zeebe) can be started via a camunda.sh script.

  • When starting the Single Application via the script, a user can define a profile (operate, zeebe, or gateway) to start only specific application parts. The profiles operate and zeebe are applied by default.
  • Align the configurations between Operate and Zeebe
  • Ensures that all health checks are included depending on which part of the application is started.
  • Change: Now, the health check shows details to help understand which part of the application might not be up.
  • Ensures that the existing standalone application can still be started as usual and behave as usual.

Related issues

related #17579

@github-actions github-actions bot added component/zeebe Related to the Zeebe component/team component/operate Related to the Operate component/team labels May 2, 2024
Copy link
Contributor

github-actions bot commented May 2, 2024

Operate Test Results

798 tests  ±0   795 ✅ ±0   7m 20s ⏱️ - 1m 7s
132 suites ±0     3 💤 ±0 
132 files   ±0     0 ❌ ±0 

Results for commit 672dc9e. ± Comparison against base commit 6a0b84e.

♻️ This comment has been updated with latest results.

@romansmirnov romansmirnov force-pushed the rs-ope-zb-single-application branch 27 times, most recently from 1b26874 to 6f6769d Compare May 7, 2024 18:19
@romansmirnov romansmirnov force-pushed the rs-ope-zb-single-application branch 3 times, most recently from 32ce932 to 5b5b0f8 Compare May 7, 2024 18:53
Copy link
Collaborator

@houssain-barouni houssain-barouni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@romansmirnov are you planning to create a Dockerfile that starts CamundaStandalone?
I am also wondering how we will solve the liveness probe (Operate requires the Broker to start, but Kubernetes will not open the network to the Broker (to the single app service) as the liveness probe still return false as Operate is still not ready)

@romansmirnov
Copy link
Member Author

are you planning to create a Dockerfile that starts CamundaStandalone?

As discussed, we will do this once Tasklist is part of the Single Application as well.

I am also wondering how we will solve the liveness probe (Operate requires the Broker to start, but Kubernetes will not open the network to the Broker (to the single app service) as the liveness probe still return false as Operate is still not ready)

It should be tackled in a separate issue. I think a way to achieve that would be to depend on the context to fetch that, i.e., if Zeebe is started as part of the application, it could be retrieved directly from Zeebe. Later, with the unified REST API, we could get this information by using the topology request. I think there are different options on how to achieve it.

@romansmirnov romansmirnov added this pull request to the merge queue May 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 16, 2024
@romansmirnov romansmirnov added this pull request to the merge queue May 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 16, 2024
@romansmirnov romansmirnov added this pull request to the merge queue May 16, 2024
Merged via the queue into main with commit 3ff2ec7 May 16, 2024
45 of 46 checks passed
@romansmirnov romansmirnov deleted the rs-ope-zb-single-application branch May 16, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/operate Related to the Operate component/team component/zeebe Related to the Zeebe component/team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants