Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport stable/8.0] Resolve flaky timer test #11051

Closed
wants to merge 1 commit into from
Closed

[Backport stable/8.0] Resolve flaky timer test #11051

wants to merge 1 commit into from

Conversation

backport-action
Copy link
Collaborator

Description

Backport of #11033 to stable/8.0.

relates to #10272

@remcowesterhoud @github-actions
fix(test): resolve flaky test
641fd64 
We are not entirely sure what the cause of the flakyness is, however by improving the assertions to be more specific to what this test is supposed to fix we expect that the flakyness is resolved.

(cherry picked from commit 3ca46f0)
@backport-action backport-action mentioned this pull request Nov 18, 2022
Merged
9 tasks
@github-actions
Copy link
Contributor

Test Results

   783 files   -   85     783 suites   - 85   1h 56m 31s ⏱️ - 5m 24s
5 474 tests  - 742  5 469 ✔️  - 743  4 💤 ±0  1 ❌ +1 
5 784 runs   - 778  5 777 ✔️  - 779  6 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 641fd64. ± Comparison against base commit 6980ce4.

@remcowesterhoud
Copy link
Contributor

remcowesterhoud commented Nov 18, 2022 •
edited

The test seems like a legit failure. We should check if we should really backport this fix to 8.0

@saig0 saig0 self-requested a review November 21, 2022 09:12
saig0
saig0 approved these changes Nov 21, 2022
View reviewed changes
Copy link
Member

@saig0 saig0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@remcowesterhoud
Copy link
Contributor

bors merge

zeebe-bors-camunda bot added a commit that referenced this pull request Nov 22, 2022
@zeebe-bors-camunda @remcowesterhoud
merge: #11051
27fd39a 
11051: [Backport stable/8.0] Resolve flaky timer test r=remcowesterhoud a=backport-action

# Description
Backport of #11033 to `stable/8.0`.

relates to #10272

Co-authored-by: Remco Westerhoud <remco@westerhoud.nl>
@zeebe-bors-camunda
Copy link
Contributor

Build failed:

@remcowesterhoud
Copy link
Contributor

This fix is incompatible with version 8.0 as the timer TRIGGERED event for start events does not contain a properly set processInstanceKey. This was fixed in 8.1.

@remcowesterhoud remcowesterhoud deleted the backport-11033-to-stable/8.0 branch November 23, 2022 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saig0 saig0 saig0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@backport-action @remcowesterhoud @saig0