Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add activatedElementInstanceKeys to modification record template #10733

Merged
merged 2 commits into from
Oct 17, 2022
Merged

Add activatedElementInstanceKeys to modification record template #10733

merged 2 commits into from
Oct 17, 2022

Conversation

remcowesterhoud
Copy link
Contributor

@remcowesterhoud remcowesterhoud commented Oct 17, 2022 •
edited

Description

Adds the new activatedElementInstanceKeys to the modification record template for ElasticSearch.

Related issues

closes #10732

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/1.3) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • New content is added to the release announcement
  • If the PR changes how BPMN processes are validated (e.g. support new BPMN element) then the Camunda modeling team should be informed to adjust the BPMN linting.

Please refer to our review guidelines.

@remcowesterhoud remcowesterhoud force-pushed the 10732_modification_record_template branch from 39f5598 to f6c117c Compare October 17, 2022 08:09
@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2022 •
edited

Test Results

   771 files   -    168     771 suites   - 168   1h 43m 39s ⏱️ -59s
6 195 tests  - 1 326  6 187 ✔️  - 1 327  7 💤 ±0  1 ❌ +1 
6 366 runs   - 1 345  6 356 ✔️  - 1 346  9 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit c3acb60. ± Comparison against base commit f0cca91.

♻️ This comment has been updated with latest results.

@remcowesterhoud remcowesterhoud force-pushed the 10732_modification_record_template branch from f6c117c to 1e2141e Compare October 17, 2022 09:23
@remcowesterhoud
fix(protocol): add getActivatedElementInstanceKeys to interface
c3acb60 
This method needs to be part of the interface in order for the ElasticSearchIT to generate a record containing this field, and verifying exporting works as expected.
saig0
saig0 approved these changes Oct 17, 2022
View reviewed changes
Copy link
Member

@saig0 saig0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@remcowesterhoud LGTM. 👍

bors merge

@zeebe-bors-camunda
Copy link
Contributor

Build succeeded:

@zeebe-bors-camunda zeebe-bors-camunda bot merged commit 7fb27df into main Oct 17, 2022
@zeebe-bors-camunda zeebe-bors-camunda bot deleted the 10732_modification_record_template branch October 17, 2022 09:49
@backport-action backport-action mentioned this pull request Oct 17, 2022
Merged
@backport-action
Copy link
Collaborator

Successfully created backport PR #10734 for stable/8.1.

zeebe-bors-camunda bot added a commit that referenced this pull request Oct 17, 2022
@zeebe-bors-camunda @remcowesterhoud
merge: #10734
c5c8e69 
10734: [Backport stable/8.1] Add activatedElementInstanceKeys to modification record template r=remcowesterhoud a=backport-action

# Description
Backport of #10733 to `stable/8.1`.

relates to #10732

Co-authored-by: Remco Westerhoud <remco@westerhoud.nl>
@korthout korthout added the version:8.1.2 Marks an issue as being completely or in parts released in 8.1.2 label Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saig0 saig0 saig0 approved these changes

Assignees
No one assigned
Labels
version:8.1.2 Marks an issue as being completely or in parts released in 8.1.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fail to export the process instance modification record to Elasticsearch
4 participants
@remcowesterhoud @backport-action @saig0 @korthout