Commits on Oct 13, 2022

1. feat(engine): distribute deployment in post commit tasks …

   This change makes it so that we do not distribute a deployment during the processing of the CREATE command, but as post commit task afters this command has been processed.
   
   The reasoning behind this change is that the writing of the deployment distribution events/commands could happen in an unexpected order. This is because of the event buffering. Once we write an event this gets buffered. When we notify a different partition about the deployment it will write (and possibly process) the command immediately. This results in a situation where the different partition could write it's commands/events before we commands/events of the CREATE command have been written, making the ordering seem backwards.
   
   E.g.:
   1. We receive a Deployment.CREATE command
   
   2. During processing we will write the DeploymentDistribution.DISTRIBUTING event. During processing we also send a message to the other partitions in order to distribute the deployment.
   
   3. The DeploymentDistribution.DISTRIBUTING event is written to the buffer. Nothing is written to the log stream yet. The other partition receives the message and writes a Deployment.DISTRIBUTE command. At this point this partition is idle so it will immediately start processing this command.
   
   4. Here we run into a race condition. If the second partition sends the response back to the first partition before the first partition has finished processing the Deployment.CREATE command it will write the DeploymentDistribution.COMPLETE before it writes the buffered events.
   
   (cherry picked from commit 33070a4)

   

   remcowesterhoud authored and github-actions[bot] committed Oct 13, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for 918f864
   • Browse repository at this point

   Copy the full SHA

   918f864 View commit details

   Browse the repository at this point in the history