-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport stable/8.0] ci: merge deploy and auto-merge workflows into unified CI workflow #10657
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just some questions in regards to job setup only effective for the main branch.
@@ -413,3 +413,140 @@ jobs: | |||
name: Event File | |||
path: ${{ github.event_path }} | |||
retention-days: 1 | |||
deploy-snapshots: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ everything from here with the github.ref == 'refs/heads/main'
conditions is just there for alignment? as effectively only auto-merge would be relevant. (Given dependabot creates PRs against stable branches)
Or should we adjust the snapshot steps to work for stable branches? e.g. pushing a 3.0.X-SNAPSHOT docker image?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it's just for alignment. I think running this for branches other than main would be a separate topic and shouldn't stop us from backporting this.
version: SNAPSHOT | ||
push: true | ||
distball: ${{ steps.build-zeebe.outputs.distball }} | ||
notify-if-failed: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ hm might this actually also be useful to get notified on? so would we need to adjust it to run on a stable/*
branch and report? But maybe not used and definitely out of scope as this wasn't the case before anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah definitely out of scope and not relevant until we actually run the deploy jobs on branches other than main.
bors r+ |
Build succeeded: |
manual backport of #10616