Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport stable/8.0] ci: merge deploy and auto-merge workflows into unified CI workflow #10657

Merged
merged 2 commits into from
Oct 10, 2022

Conversation

lenaschoenburg
Copy link
Member

@lenaschoenburg lenaschoenburg commented Oct 10, 2022

manual backport of #10616

The test summary job already depends on java checks and go linting.

(cherry picked from commit db3f85a)
@lenaschoenburg lenaschoenburg marked this pull request as ready for review October 10, 2022 15:02
Copy link
Contributor

@megglos megglos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just some questions in regards to job setup only effective for the main branch.

@@ -413,3 +413,140 @@ jobs:
name: Event File
path: ${{ github.event_path }}
retention-days: 1
deploy-snapshots:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ everything from here with the github.ref == 'refs/heads/main' conditions is just there for alignment? as effectively only auto-merge would be relevant. (Given dependabot creates PRs against stable branches)

Or should we adjust the snapshot steps to work for stable branches? e.g. pushing a 3.0.X-SNAPSHOT docker image?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's just for alignment. I think running this for branches other than main would be a separate topic and shouldn't stop us from backporting this.

version: SNAPSHOT
push: true
distball: ${{ steps.build-zeebe.outputs.distball }}
notify-if-failed:
Copy link
Contributor

@megglos megglos Oct 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ hm might this actually also be useful to get notified on? so would we need to adjust it to run on a stable/* branch and report? But maybe not used and definitely out of scope as this wasn't the case before anyway.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah definitely out of scope and not relevant until we actually run the deploy jobs on branches other than main.

@lenaschoenburg
Copy link
Member Author

bors r+

@zeebe-bors-camunda
Copy link
Contributor

Build succeeded:

@zeebe-bors-camunda zeebe-bors-camunda bot merged commit d792c31 into stable/8.0 Oct 10, 2022
@zeebe-bors-camunda zeebe-bors-camunda bot deleted the backport-10616-to-stable/8.0 branch October 10, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants