Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPE during PI modification #10601

Merged
merged 2 commits into from
Oct 5, 2022
Merged

Fix NPE during PI modification #10601

merged 2 commits into from
Oct 5, 2022

Commits on Oct 4, 2022

  1. test(engine): verify termination of multi instance body and nested el…

    …ement
    
    If a command is received in which both the multi instance body, as well as the nested element gets terminated we should be able to handle this without exceptions.
    remcowesterhoud committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    5df6a7d View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2022

  1. fix(engine): prevent NPE during termination

    A command could contain multiple terminate instruction that result in the termination of the same element instance. For example, when we have a sub process and a nested element. If both this sub process and the nested element are part of the terminate instructions, the nested element will be terminated twice.
    
    When we receive the command we verify that all instances exist. However, once the first terminate instruction terminates the element, the instance no longer exist for the second terminate instruction. When this occurs we should ignore the terminate instruction.
    remcowesterhoud committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    43b0a1d View commit details
    Browse the repository at this point in the history