Minimize usage of uninitialized BrokerCfg objects #10356
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR attempts to minimize usages of uninitialized
BrokerCfg
objects. Previously, you would create a configuration, then have to call init for it to be usable. The idea here is to try and enforce that you cannot create an unusableBrokerCfg
object in general.Unfortunately many, many places in tests do so, and sometimes create instances via reflection. I've left these for now, but open to suggestions on how best to tackle this.
This also removes the usage of two beans to initialize the
BrokerCfg
as introduced in #10354.Related issues
related #9996
depends on #10354
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/1.3
) to the PR, in case that fails you need to create backports manually.Testing:
Documentation:
Please refer to our review guidelines.