Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport stable/1.3] fix(raft): follower resets pending snapshot after rejecting install request #10211

Merged
merged 12 commits into from
Aug 30, 2022

Conversation

deepthidevaki
Copy link
Contributor

Description

Backport #10183

closes #10180 #10202

deepthidevaki and others added 11 commits August 29, 2022 15:07
When comparing compacted logs, not all entries exist in all logs. So compare only the entries that exist.

(cherry picked from commit 773dfa2)
When follower responds with any error, leader restarts send the snapshot from the initial chunk. When the follower has not resets its state, then the follower is not expecting the initial chunk. As a result, the follower reject the requests and this will continue endlessly.

(cherry picked from commit 9aba732)
There were some cases where the log is not reset and leads to scenarios where a follower is not able to replicate new events. This case is explained in #10183 (comment)

(cherry picked from commit 4c82bd9)
(cherry picked from commit 1362765)
Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com>
(cherry picked from commit 69df0fa)
@deepthidevaki deepthidevaki changed the base branch from main to stable/1.3 August 29, 2022 13:12
@deepthidevaki deepthidevaki changed the title [Backport stable/8.0] fix(raft): follower resets pending snapshot after rejecting install request [Backport stable/1.3] fix(raft): follower resets pending snapshot after rejecting install request Aug 29, 2022
@deepthidevaki
Copy link
Contributor Author

@oleschoenburg Nothing to look for, there was a minor merge conflict which failed auto backport.

Copy link
Member

@oleschoenburg oleschoenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

zeebe-bors-camunda bot added a commit that referenced this pull request Aug 29, 2022
10211: [Backport stable/1.3] fix(raft): follower resets pending snapshot after rejecting install request r=oleschoenburg a=deepthidevaki

## Description

Backport #10183

closes #10180 #10202

Co-authored-by: Deepthi Devaki Akkoorath <deepthidevaki@gmail.com>
Co-authored-by: Deepthi Devaki Akkoorath <deepthidevaki@users.noreply.github.com>
@zeebe-bors-camunda
Copy link
Contributor

Build failed:

@deepthidevaki
Copy link
Contributor Author

bors merge

zeebe-bors-camunda bot added a commit that referenced this pull request Aug 29, 2022
10211: [Backport stable/1.3] fix(raft): follower resets pending snapshot after rejecting install request r=deepthidevaki a=deepthidevaki

## Description

Backport #10183

closes #10180 #10202

Co-authored-by: Deepthi Devaki Akkoorath <deepthidevaki@gmail.com>
Co-authored-by: Deepthi Devaki Akkoorath <deepthidevaki@users.noreply.github.com>
@zeebe-bors-camunda
Copy link
Contributor

Build failed:

@deepthidevaki
Copy link
Contributor Author

bors merge

zeebe-bors-camunda bot added a commit that referenced this pull request Aug 30, 2022
10211: [Backport stable/1.3] fix(raft): follower resets pending snapshot after rejecting install request r=deepthidevaki a=deepthidevaki

## Description

Backport #10183

closes #10180 #10202

Co-authored-by: Deepthi Devaki Akkoorath <deepthidevaki@gmail.com>
Co-authored-by: Deepthi Devaki Akkoorath <deepthidevaki@users.noreply.github.com>
@zeebe-bors-camunda
Copy link
Contributor

Build failed:

@deepthidevaki
Copy link
Contributor Author

bors retry

zeebe-bors-camunda bot added a commit that referenced this pull request Aug 30, 2022
10211: [Backport stable/1.3] fix(raft): follower resets pending snapshot after rejecting install request r=deepthidevaki a=deepthidevaki

## Description

Backport #10183

closes #10180 #10202

Co-authored-by: Deepthi Devaki Akkoorath <deepthidevaki@gmail.com>
Co-authored-by: Deepthi Devaki Akkoorath <deepthidevaki@users.noreply.github.com>
@zeebe-bors-camunda
Copy link
Contributor

Build failed:

@deepthidevaki
Copy link
Contributor Author

😭

bors merge

zeebe-bors-camunda bot added a commit that referenced this pull request Aug 30, 2022
10211: [Backport stable/1.3] fix(raft): follower resets pending snapshot after rejecting install request r=deepthidevaki a=deepthidevaki

## Description

Backport #10183

closes #10180 #10202

Co-authored-by: Deepthi Devaki Akkoorath <deepthidevaki@gmail.com>
Co-authored-by: Deepthi Devaki Akkoorath <deepthidevaki@users.noreply.github.com>
@zeebe-bors-camunda
Copy link
Contributor

Build failed:

@deepthidevaki
Copy link
Contributor Author

bors merge

@zeebe-bors-camunda zeebe-bors-camunda bot merged commit 0b84e3e into stable/1.3 Aug 30, 2022
@zeebe-bors-camunda zeebe-bors-camunda bot deleted the backport-10183-to-stable/1.3 branch August 30, 2022 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Follower cannot receive snapshot because "chunk received out of order"
2 participants