Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport stable/8.0] fix(raft): follower resets pending snapshot after rejecting install request #10210

Merged
merged 11 commits into from
Aug 29, 2022
Merged

[Backport stable/8.0] fix(raft): follower resets pending snapshot after rejecting install request #10210

merged 11 commits into from
Aug 29, 2022

Conversation

deepthidevaki
Copy link
Contributor

Description

Backport #10183

closes #10180 #10202

deepthidevaki and others added 11 commits August 29, 2022 15:01
@deepthidevaki
test(raft): allow comparing compacted logs
b0e084c 
When comparing compacted logs, not all entries exist in all logs. So compare only the entries that exist.

(cherry picked from commit 773dfa2)
@deepthidevaki
test(raft): extend RandomizedRaftTest with snapshot and compaction
a5b16c4 
(cherry picked from commit 5db2932)
@deepthidevaki
fix(raft): reset snapshot replication on error in follower
1a16a21 
When follower responds with any error, leader restarts send the snapshot from the initial chunk. When the follower has not resets its state, then the follower is not expecting the initial chunk. As a result, the follower reject the requests and this will continue endlessly.

(cherry picked from commit 9aba732)
@deepthidevaki
test(raft): write different content to each chunk to improve test rel…
ceb890d 
…iability

(cherry picked from commit fe11e34)
@deepthidevaki
test(raft): improve assertion failure message
a9e809b 
(cherry picked from commit 6a39814)
@deepthidevaki
fix(raft): reset log always on receiving a snapshot
20d5aca 
There were some cases where the log is not reset and leads to scenarios where a follower is not able to replicate new events. This case is explained in #10183 (comment)

(cherry picked from commit 4c82bd9)
@deepthidevaki
refactor(raft): remove unused snapshot listener
0a72e69 
(cherry picked from commit 43c96cd)
@deepthidevaki
test(raft): improve assertion failure message
1f1ed1e 
(cherry picked from commit d79b730)
@deepthidevaki
test(raft): remove unnecessary seek
a85f521 
(cherry picked from commit 1362765)
@deepthidevaki
refactor(raft): fix typo in error message
9dc8025 
(cherry picked from commit 455a09c)
@deepthidevaki
test(raft): allow snapshot with one chunk in randomized tests
886ccb1 
Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com>
(cherry picked from commit 69df0fa)
@oleschoenburg
Copy link
Member

@deepthidevaki Anything to look out for or is this just a pro forma review?

@deepthidevaki
Copy link
Contributor Author

@oleschoenburg Nothing to look for. There was minor merge conflict that failed backport action.

oleschoenburg
oleschoenburg approved these changes Aug 29, 2022
View reviewed changes
Copy link
Member

@oleschoenburg oleschoenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@zeebe-bors-camunda
Copy link
Contributor

Build succeeded:

@zeebe-bors-camunda zeebe-bors-camunda bot merged commit f687fae into stable/8.0 Aug 29, 2022
@zeebe-bors-camunda zeebe-bors-camunda bot deleted the backport-10183-to-stable/8.0 branch August 29, 2022 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleschoenburg oleschoenburg oleschoenburg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@deepthidevaki @oleschoenburg