Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy writers #10203

Merged
merged 8 commits into from
Aug 29, 2022
Merged

Remove legacy writers #10203

merged 8 commits into from
Aug 29, 2022

Conversation

Zelldon
Copy link
Member

@Zelldon Zelldon commented Aug 26, 2022

Description

Removes the usage of the old LegacyWriter interface and implementation. Furthermore, it removes the need of the TypedStreamWriterFactor from the Context and tests.

The StreamProcessorHealthTests have been rewritten to use the new extension and mocked record processor. It felt much easier to write such test I have to say.

Related issues

closes #9724

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/1.3) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • New content is added to the release announcement
  • If the PR changes how BPMN processes are validated (e.g. support new BPMN element) then the Camunda modeling team should be informed to adjust the BPMN linting.

Please refer to our review guidelines.

@github-actions
Copy link
Contributor

Test Results

   852 files  ±    0     852 suites  ±0   1h 39m 12s ⏱️ + 1m 15s
6 272 tests +116  6 262 ✔️ +117  10 💤  - 1  0 ±0 
6 456 runs  +116  6 446 ✔️ +117  10 💤  - 1  0 ±0 

Results for commit 1deecf3. ± Comparison against base commit a66af76.

Copy link
Contributor

@deepthidevaki deepthidevaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

bors r+

@zeebe-bors-camunda
Copy link
Contributor

Build succeeded:

@zeebe-bors-camunda zeebe-bors-camunda bot merged commit bbd0e5d into main Aug 29, 2022
@zeebe-bors-camunda zeebe-bors-camunda bot deleted the zell-rm-legacy-writers branch August 29, 2022 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove LogStream writers from Engine
2 participants