Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add canWriteRecord method to RecordBatch #10181

Merged
merged 4 commits into from
Aug 26, 2022
Merged

Conversation

Zelldon
Copy link
Member

@Zelldon Zelldon commented Aug 25, 2022

Description

This method can be used to verify whether a record length could potentially be appended to the batch, this is useful if you don't want to append the record right now, like if you add more and more data and always check whether it still fits. This is used in the JobBatchCollector for example.

Removed the maxMessageLength, since this was only used in one place and I felt is somehow breaks the abstraction, especially it would block us to really remove the write from the implementation.

Related issues

related #10001

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/1.3) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • New content is added to the release announcement
  • If the PR changes how BPMN processes are validated (e.g. support new BPMN element) then the Camunda modeling team should be informed to adjust the BPMN linting.

Please refer to our review guidelines.

This method can be used to verify whether a record length could potentially appended to the batch, this is useful if you don't want to append the record right now, like if you add more and more data and always check whether it still fits. This is used in the JobBatchCollector for example.
@github-actions
Copy link
Contributor

github-actions bot commented Aug 25, 2022

Test Results

   852 files  ±  0     852 suites  ±0   1h 39m 19s ⏱️ - 7m 55s
6 602 tests +60  6 591 ✔️ +61  11 💤  - 1  0 ±0 
6 786 runs  +60  6 775 ✔️ +61  11 💤  - 1  0 ±0 

Results for commit d8a7917. ± Comparison against base commit 82f7212.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@deepthidevaki deepthidevaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Zelldon
Copy link
Member Author

Zelldon commented Aug 26, 2022

bors r+

@zeebe-bors-camunda
Copy link
Contributor

Build succeeded:

@zeebe-bors-camunda zeebe-bors-camunda bot merged commit ab0a90b into main Aug 26, 2022
@zeebe-bors-camunda zeebe-bors-camunda bot deleted the zell-canWrite branch August 26, 2022 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants