Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small Clean up #10171

Merged
merged 3 commits into from
Aug 25, 2022
Merged

Small Clean up #10171

merged 3 commits into from
Aug 25, 2022

Conversation

Zelldon
Copy link
Member

@Zelldon Zelldon commented Aug 24, 2022

Description

Related issues

related to #10001

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/1.3) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • New content is added to the release announcement
  • If the PR changes how BPMN processes are validated (e.g. support new BPMN element) then the Camunda modeling team should be informed to adjust the BPMN linting.

Please refer to our review guidelines.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 24, 2022 •
edited

Test Results

   852 files  ±    0     852 suites  ±0   1h 43m 49s ⏱️ -24s
6 697 tests +113  6 686 ✔️ +113  11 💤 ±0  0 ❌ ±0 
6 881 runs  +113  6 870 ✔️ +113  11 💤 ±0  0 ❌ ±0 

Results for commit b41addb. ± Comparison against base commit ec06278.

♻️ This comment has been updated with latest results.

deepthidevaki
deepthidevaki approved these changes Aug 24, 2022
View reviewed changes
Copy link
Contributor

@deepthidevaki deepthidevaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

engine/src/main/java/io/camunda/zeebe/streamprocessor/ProcessingStateMachine.java Outdated
@@ -157,8 +148,7 @@ public ProcessingStateMachine(
recordValues = context.getRecordValues();
logStreamReader = context.getLogStreamReader();
logStreamWriter = context.getLogStreamWriter();
logStream = context.getLogStream();
zeebeState = context.getZeebeState();
final LogStream logStream = context.getLogStream();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔧 this is only used to get the partitionId. You can merge this with that (line 161)

@Zelldon
Copy link
Member Author

Zelldon commented Aug 25, 2022

bors r+

@zeebe-bors-camunda
Copy link
Contributor

Build succeeded:

@zeebe-bors-camunda zeebe-bors-camunda bot merged commit 8b062e9 into main Aug 25, 2022
@zeebe-bors-camunda zeebe-bors-camunda bot deleted the zell-clean-up branch August 25, 2022 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthidevaki deepthidevaki deepthidevaki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Zelldon @deepthidevaki