Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid race condition when polling for topology #10086

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

npepinpe
Copy link
Member

Description

This PR fixes a potential race condition when starting the EmbeddedBrokerRule. We poll for the topology and wait until it's complete. Unfortunately, if we're too fast and the request is rejected, the .join() will throw, which will be rethrown by Awaitility (as when using untilAsserted it only catches AssertionError), failing the test. By ignoring exceptions here we can focus on just failing when the topology is never complete (Awaitility will print out the last failure in that case).

Related issues

related to #10084

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/1.3) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • New content is added to the release announcement
  • If the PR changes how BPMN processes are validated (e.g. support new BPMN element) then the Camunda modeling team should be informed to adjust the BPMN linting.

Please refer to our review guidelines.

@github-actions
Copy link
Contributor

Test Results

   843 files  ±    0     843 suites  ±0   1h 43m 27s ⏱️ + 5m 27s
6 376 tests  - 103  6 365 ✔️  - 103  11 💤 ±0  0 ±0 
6 560 runs   - 103  6 549 ✔️  - 103  11 💤 ±0  0 ±0 

Results for commit 848cc83. ± Comparison against base commit 52f56d9.

Copy link
Member

@lenaschoenburg lenaschoenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@zeebe-bors-camunda
Copy link
Contributor

Build succeeded:

@zeebe-bors-camunda zeebe-bors-camunda bot merged commit b241c19 into main Aug 17, 2022
@zeebe-bors-camunda zeebe-bors-camunda bot deleted the np-flaky-condition branch August 17, 2022 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants