[Backport stable/8.0] Abbreviate Deployment Distribution records in compact logger #10075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The abbreviations of the compact logger are applied on the text sequentially. So far the order didn't matter because the keys don't overlap. But, I want to add some new keys that do overlap. This changes the abbreviations from a Map to a List of Entries to strictly preserve the defined ordering. (cherry picked from commit 9590133)
Deployment and Deployment_Distribution record types should be abbreviated correctly. However, only DISTRIBUTED was abbreviated, which is an intent and not a record type. This led to some strange logs when reading the compact log. By removing the DISTRIBUTED abbreviation and adding abbreviations for the record types we get a much cleaner log. (cherry picked from commit b54a409)
(cherry picked from commit 855769c)
10 tasks
|
Build failed: |
|
bors retry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #10073 to
stable/8.0.relates to #10064