Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document ProcessingScheduleService.runAtFixedRate #10072

Merged
merged 1 commit into from
Aug 15, 2022

Conversation

korthout
Copy link
Member

Description

The ProcessingScheduleService has a runAtFixedRate which is implemented in a simple way: run the task after a delay and then schedule itself. But there are some quirks around this that should be clear to the caller.

Specifically, that there is an initial delay before the task is run, and that due to the way it reschedules the task, time traveling only affects the currently scheduled delay.

Related issues

related to #10064

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/1.3) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • New content is added to the release announcement
  • If the PR changes how BPMN processes are validated (e.g. support new BPMN element) then the Camunda modeling team should be informed to adjust the BPMN linting.

Please refer to our review guidelines.

The ProcessingScheduleService has a runAtFixedRate which is implemented
in a simple way (run the task after a delay and then schedule itself).
But there are some quircks around this that should be clear to the
caller.
@github-actions
Copy link
Contributor

github-actions bot commented Aug 15, 2022

Test Results

   843 files  ±  0     843 suites  ±0   1h 37m 59s ⏱️ -50s
6 442 tests +76  6 431 ✔️ +76  11 💤 ±0  0 ±0 
6 626 runs  +76  6 615 ✔️ +76  11 💤 ±0  0 ±0 

Results for commit 5182043. ± Comparison against base commit e1a5ee9.

♻️ This comment has been updated with latest results.

@korthout korthout marked this pull request as ready for review August 15, 2022 17:18
Copy link
Contributor

@pihme pihme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@zeebe-bors-camunda
Copy link
Contributor

Build succeeded:

@zeebe-bors-camunda zeebe-bors-camunda bot merged commit 5bf6401 into main Aug 15, 2022
@zeebe-bors-camunda zeebe-bors-camunda bot deleted the korthout-doc-schedule-at-fixed-rate branch August 15, 2022 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants