-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(engine): merge two legacy interfaces together #10057
refactor(engine): merge two legacy interfaces together #10057
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just so I get it right. The idea is that we then in the end just replace the Writer interface with the new Builder interface to create the result, correct? :)
If this is the case makes sense to me.
...java/io/camunda/zeebe/engine/processing/streamprocessor/writers/LegacyTypedStreamWriter.java
Outdated
Show resolved
Hide resolved
6853d17
to
3ecc0a8
Compare
@Zelldon please have another look. I rebased everything and reduced the one legacy interface. Now, the next step will be to replace usages of this one legacy interface with new tasks - scheduled via Details still need to be figured out, but this is the general gist of it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
bors merge |
Build succeeded: |
Description
LegacyTypedStreamWriter
already extendedLegacyTypedCommandWriter
LegacyTypedCommandWriter
withLegacyTypedStreamWriter
LegacyTypedCommandWriter
Related issues
relates to #9724
Definition of Done
Code changes:
backport stable/1.3
) to the PR, in case that fails you need to create backports manually.Testing:
Documentation:
Please refer to our review guidelines.