Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(engine): merge two legacy interfaces together #10057

Merged
merged 2 commits into from
Aug 15, 2022

Conversation

pihme
Copy link
Contributor

@pihme pihme commented Aug 10, 2022

Description

  • LegacyTypedStreamWriter already extended LegacyTypedCommandWriter
  • This PR replaces all references to LegacyTypedCommandWriter with LegacyTypedStreamWriter
  • It then merges the two interfaces and deleted LegacyTypedCommandWriter
  • The net effect of this, is that we only need to replace one interface going forward

Related issues

relates to #9724

Definition of Done

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/1.3) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • New content is added to the release announcement
  • If the PR changes how BPMN processes are validated (e.g. support new BPMN element) then the Camunda modeling team should be informed to adjust the BPMN linting.

Please refer to our review guidelines.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 10, 2022

Test Results

   768 files   -   75     768 suites   - 75   24m 28s ⏱️ - 1h 15m 48s
6 032 tests  - 367  6 021 ✔️  - 367  11 💤 ±0  0 ±0 
6 216 runs   - 367  6 205 ✔️  - 367  11 💤 ±0  0 ±0 

Results for commit c4abc4e. ± Comparison against base commit 661e6bb.

♻️ This comment has been updated with latest results.

@pihme pihme marked this pull request as ready for review August 11, 2022 07:53
@pihme pihme requested a review from Zelldon August 11, 2022 07:53
Copy link
Member

@Zelldon Zelldon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just so I get it right. The idea is that we then in the end just replace the Writer interface with the new Builder interface to create the result, correct? :)

If this is the case makes sense to me.

@pihme pihme force-pushed the engine-abstraction-merge-legacy-interfaces branch from 6853d17 to 3ecc0a8 Compare August 15, 2022 09:55
@pihme pihme requested a review from Zelldon August 15, 2022 09:56
@pihme
Copy link
Contributor Author

pihme commented Aug 15, 2022

@Zelldon please have another look. I rebased everything and reduced the one legacy interface.

Now, the next step will be to replace usages of this one legacy interface with new tasks - scheduled via ProcessingScheduleService. This task will probably get an object similar to the response builder at runtime. I say similar, because I do want to define a reduced builder (i.e. result has only records, no side effects, no response)

Details still need to be figured out, but this is the general gist of it.

Copy link
Member

@Zelldon Zelldon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@pihme
Copy link
Contributor Author

pihme commented Aug 15, 2022

bors merge

@zeebe-bors-camunda
Copy link
Contributor

Build succeeded:

@zeebe-bors-camunda zeebe-bors-camunda bot merged commit 1f09e85 into main Aug 15, 2022
@zeebe-bors-camunda zeebe-bors-camunda bot deleted the engine-abstraction-merge-legacy-interfaces branch August 15, 2022 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants