Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engine abstraction remove obsolete code #10050

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

pihme
Copy link
Contributor

@pihme pihme commented Aug 9, 2022

Description

Removes code that is no longer needed. Started out with a class, and then I found more.

Related issues

related to #9727

Definition of Done

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/1.3) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • New content is added to the release announcement
  • If the PR changes how BPMN processes are validated (e.g. support new BPMN element) then the Camunda modeling team should be informed to adjust the BPMN linting.

Please refer to our review guidelines.

@pihme pihme requested a review from Zelldon August 9, 2022 15:57
@pihme pihme changed the title Engine abstraction emove obsolete code Engine abstraction remove obsolete code Aug 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2022

Test Results

   812 files  +  1     812 suites  +1   1h 58m 6s ⏱️ + 19m 58s
6 047 tests  - 36  6 035 ✔️  - 38  10 💤 ±0  2 +2 
6 235 runs   - 36  6 223 ✔️  - 38  10 💤 ±0  2 +2 

For more details on these failures, see this check.

Results for commit b85075c. ± Comparison against base commit 77f9f1d.

Copy link
Member

@Zelldon Zelldon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Peter 🏕️ 🧹 👍

@pihme
Copy link
Contributor Author

pihme commented Aug 10, 2022

bors merge

@zeebe-bors-camunda
Copy link
Contributor

Build succeeded:

@zeebe-bors-camunda zeebe-bors-camunda bot merged commit 3487dab into main Aug 10, 2022
@zeebe-bors-camunda zeebe-bors-camunda bot deleted the engine-abstraction-code-cleanup branch August 10, 2022 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants