Clarify DEAD partition state in Grafana dashboard #10046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A partition can either be HEALTHY, UNHEALTHY or DEAD. However, we never had any way to show this in the partition health overview. This adds an additional field override for health -1 -> DEAD with the red color. To differentiate it from UNHEALTHY, I've also changed the color of UNHEALTHY to orange.
The README is a great source to test the Grafana dashboard locally. But I struggled a bit with finding how to login. This clarifies it a bit.
|
@ Reviewer, when I exported the dashboard a lot of unnecessary changes came along with it. I've extracted those to d36e3ef. Please let me know if you think those should be part of this PR as well. I'll keep the PR in draft mode until this is cleared up. |
Zelldon
reviewed
Aug 10, 2022
There was a problem hiding this comment.
I guess you exported the dashboard via the locally testing? Please make sure to change the dashboard here http://34.77.165.228/d/NzsO1mUnk/zeebe-overview?orgId=1&refresh=10s and export that to the repo. This is how we normally do it, then the version and other properties should be ok.
| @@ -16,7 +16,7 @@ file](../docker/compose/docker-compose.yaml) in combination with the one [here]( | |||
| docker-compose --project-directory ./ -f docker-compose.yml -f ../docker/compose/docker-compose.yaml up -d | |||
| ``` | |||
|
|
|||
| This will start the usual 3 brokers cluster, as well as a Grafana instance (on port 3000) and a Prometheus instance on | |||
| This will start the usual 3 brokers cluster, as well as a Grafana [instance](http://localhost:3000/) (on port 3000; login: u `admin`, p `camunda`) and a Prometheus instance on | |||
There was a problem hiding this comment.
😆 wasn't aware of this "testing guide"
korthout
force-pushed
the
korthout-10043-grafana-dead-state
branch
from
d36e3ef
to
a41f465
Compare
Zelldon
approved these changes
Aug 16, 2022
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As an incident follow-up, this clarifies the DEAD partition health state in the Grafana Zeebe Overview dashboard.
Related issues
closes #10043
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/1.3) to the PR, in case that fails you need to create backports manually.Testing:
Documentation:
Please refer to our review guidelines.