Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract reusable action for test artifact upload #10045

Merged
merged 1 commit into from
Aug 15, 2022
Merged

Extract reusable action for test artifact upload #10045

merged 1 commit into from
Aug 15, 2022

Conversation

menski
Copy link
Contributor

@menski menski commented Aug 9, 2022

Description

Create composite github action to bundle test artifact upload steps.

At the moment the steps are:

  • clean system-out from test XML output
  • upload test artifact for later use

Related issues

closes #9135

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2022 •
edited

Test Results

   841 files  +  30     841 suites  +30   1h 36m 43s ⏱️ - 2m 51s
6 273 tests +127  6 262 ✔️ +126  11 💤 +1  0 ❌ ±0 
6 457 runs  +123  6 446 ✔️ +122  11 💤 +1  0 ❌ ±0 

Results for commit c1c0fec. ± Comparison against base commit 3487dab.

♻️ This comment has been updated with latest results.

@menski menski force-pushed the 9135-post-steps-action branch 6 times, most recently from f1f703d to c1c0fec Compare August 10, 2022 07:45
@menski menski marked this pull request as ready for review August 10, 2022 07:59
@menski menski mentioned this pull request Aug 12, 2022
Closed
oleschoenburg
oleschoenburg approved these changes Aug 15, 2022
View reviewed changes
Copy link
Member

@oleschoenburg oleschoenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay 🙈

LGTM, just one minor comment to remove an unused input

.github/actions/collect-test-artifacts/action.yml Outdated Show resolved Hide resolved
@menski
chore(ci): extract reusable action for test artifact upload
c4995c0 
Create composite github action to bundle test artifact upload steps.
At the moment the steps are:
- clean system-out from test XML output
- upload test artifact for later use
@menski
Copy link
Contributor Author

menski commented Aug 15, 2022

bors r+

@zeebe-bors-camunda
Copy link
Contributor

Build succeeded:

@zeebe-bors-camunda zeebe-bors-camunda bot merged commit 661e6bb into main Aug 15, 2022
@zeebe-bors-camunda zeebe-bors-camunda bot deleted the 9135-post-steps-action branch August 15, 2022 09:28
@oleschoenburg
Copy link
Member

oleschoenburg commented Aug 15, 2022 •
edited

@menski

sorry, missed during review: we need an if: always() wherever we use the new collect-test-artifacts action, otherwise we don't upload on test failure.
Previously, this worked because the last step had an if: always(), now it doesn't because the entire composite action is skipped on failure.

Here is a run where integration tests failed but no artifacts were uploaded: 661e6bb

@menski
Copy link
Contributor Author

menski commented Aug 15, 2022

thanks for pointing out, I will create a full up PR

@menski menski mentioned this pull request Aug 16, 2022
Merged
zeebe-bors-camunda bot added a commit that referenced this pull request Aug 16, 2022
@zeebe-bors-camunda @menski
merge: #10077
17630e8 
10077: Always upload test artifacts even on failure r=menski a=menski

## Description

Always upload test archive, even if tests fail.

## Related issues

follow-up to #9135 and #10045 



Co-authored-by: Sebastian Menski <sebastian.menski@camunda.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleschoenburg oleschoenburg oleschoenburg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GHA: Bundle post-test steps into a reusable action
2 participants
@menski @oleschoenburg