Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: let dist build gateways broker client #10032

Merged
merged 1 commit into from
Aug 15, 2022

Conversation

lenaschoenburg
Copy link
Member

@lenaschoenburg lenaschoenburg commented Aug 9, 2022

Description

Builds the broker client in dist, making it available for injection. Because BrokerClient needs to schedule actors, the actor scheduler must be started before. To achieve this, BrokerClient gets a start method that does the scheduling.

Related issues

relates to #9996

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/1.3) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • New content is added to the release announcement
  • If the PR changes how BPMN processes are validated (e.g. support new BPMN element) then the Camunda modeling team should be informed to adjust the BPMN linting.

Please refer to our review guidelines.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2022

Test Results

   811 files  ±0     811 suites  ±0   1h 38m 7s ⏱️ + 3m 3s
6 183 tests  - 8  6 173 ✔️  - 8  10 💤 ±0  0 ±0 
6 371 runs   - 8  6 361 ✔️  - 8  10 💤 ±0  0 ±0 

Results for commit a00eefd. ± Comparison against base commit a301d41.

♻️ This comment has been updated with latest results.

@lenaschoenburg lenaschoenburg force-pushed the 9996-dist-builds-gateway-brokerclient branch 2 times, most recently from 1a1dc5e to bc4ed55 Compare August 9, 2022 09:40
@lenaschoenburg lenaschoenburg force-pushed the 9996-dist-builds-gateway-brokerclient branch from bc4ed55 to 3266a94 Compare August 9, 2022 11:31
@lenaschoenburg lenaschoenburg force-pushed the 9996-dist-builds-gateway-brokerclient branch from 3266a94 to a00eefd Compare August 9, 2022 13:01
@lenaschoenburg lenaschoenburg changed the title refactor: let dist build the broker client refactor: let dist build gateways broker client Aug 9, 2022
@lenaschoenburg lenaschoenburg marked this pull request as ready for review August 9, 2022 13:20
Copy link
Member

@npepinpe npepinpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lenaschoenburg
Copy link
Member Author

bors r+

@zeebe-bors-camunda
Copy link
Contributor

Build succeeded:

@zeebe-bors-camunda zeebe-bors-camunda bot merged commit a3d03d8 into main Aug 15, 2022
@zeebe-bors-camunda zeebe-bors-camunda bot deleted the 9996-dist-builds-gateway-brokerclient branch August 15, 2022 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants