Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engine abstraction code cleanup #10021

Merged
merged 3 commits into from
Aug 8, 2022

Conversation

pihme
Copy link
Contributor

@pihme pihme commented Aug 8, 2022

Description

  • Removes unnecessary references
  • Moves LegacyTypedResponseWriter to stream processor, as it is only used in this package
  • Renames LegacyTypedResponseWriter

Related issues

related to #9727

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/1.3) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • New content is added to the release announcement
  • If the PR changes how BPMN processes are validated (e.g. support new BPMN element) then the Camunda modeling team should be informed to adjust the BPMN linting.

Please refer to our review guidelines.

@pihme pihme requested a review from Zelldon August 8, 2022 09:00
@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2022

Test Results

   706 files     706 suites   1h 36m 53s ⏱️
5 291 tests 5 269 ✔️ 11 💤 8  3 🔥
5 468 runs  5 446 ✔️ 11 💤 8  3 🔥

For more details on these failures and errors, see this check.

Results for commit 349bb3b.

♻️ This comment has been updated with latest results.

Copy link
Member

@Zelldon Zelldon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍 :) Might be that some have been already removed due to the recent PR merges :)

@pihme pihme force-pushed the pihme-engine-abstraction-code-cleanup branch from 38d9c33 to 349bb3b Compare August 8, 2022 12:44
@pihme
Copy link
Contributor Author

pihme commented Aug 8, 2022

bors merge

zeebe-bors-camunda bot added a commit that referenced this pull request Aug 8, 2022
10021: Engine abstraction code cleanup r=pihme a=pihme

## Description
* Removes unnecessary references
* Moves `LegacyTypedResponseWriter` to stream processor, as it is only used in this package
* Renames `LegacyTypedResponseWriter`

## Related issues

related to #9727 



Co-authored-by: pihme <pihme@users.noreply.github.com>
@zeebe-bors-camunda
Copy link
Contributor

Build failed:

@pihme
Copy link
Contributor Author

pihme commented Aug 8, 2022

bors merge

@zeebe-bors-camunda
Copy link
Contributor

Build succeeded:

@zeebe-bors-camunda zeebe-bors-camunda bot merged commit 26c8cca into main Aug 8, 2022
@zeebe-bors-camunda zeebe-bors-camunda bot deleted the pihme-engine-abstraction-code-cleanup branch August 8, 2022 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants