-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Engine abstraction code cleanup #10021
Merged
zeebe-bors-camunda
merged 3 commits into
main
from
pihme-engine-abstraction-code-cleanup
Aug 8, 2022
Merged
Engine abstraction code cleanup #10021
zeebe-bors-camunda
merged 3 commits into
main
from
pihme-engine-abstraction-code-cleanup
Aug 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zelldon
approved these changes
Aug 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍 :) Might be that some have been already removed due to the recent PR merges :)
pihme
force-pushed
the
pihme-engine-abstraction-code-cleanup
branch
from
August 8, 2022 12:44
38d9c33
to
349bb3b
Compare
bors merge |
zeebe-bors-camunda bot
added a commit
that referenced
this pull request
Aug 8, 2022
10021: Engine abstraction code cleanup r=pihme a=pihme ## Description * Removes unnecessary references * Moves `LegacyTypedResponseWriter` to stream processor, as it is only used in this package * Renames `LegacyTypedResponseWriter` ## Related issues related to #9727 Co-authored-by: pihme <pihme@users.noreply.github.com>
Build failed: |
bors merge |
Build succeeded: |
zeebe-bors-camunda
bot
deleted the
pihme-engine-abstraction-code-cleanup
branch
August 8, 2022 15:33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
LegacyTypedResponseWriter
to stream processor, as it is only used in this packageLegacyTypedResponseWriter
Related issues
related to #9727
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/1.3
) to the PR, in case that fails you need to create backports manually.Testing:
Documentation:
Please refer to our review guidelines.