Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notify CheckpointListeners after init and replay #9916

Closed
deepthidevaki opened this issue Jul 28, 2022 · 0 comments · Fixed by #9943
Closed

Notify CheckpointListeners after init and replay #9916

deepthidevaki opened this issue Jul 28, 2022 · 0 comments · Fixed by #9943
Assignees
@deepthidevaki
Labels
kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. version:8.1.0-alpha5 Marks an issue as being completely or in parts released in 8.1.0-alpha5 version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0

Comments

@deepthidevaki
Copy link
Contributor

Description

InterpartitionCommandSender and Reciever keeps track of the latest checkpointId via CheckpointListeners. We must ensure that they have the correct valued even after failovers or restart. Currently CheckpointListeners are notified only when checkpoint record is processed. In addition, they should be notified after the processor initializes it's state, when a new listener is registerd, and CREATED record is replayed.

Ref:- #9899 (comment)
@deepthidevaki deepthidevaki added the kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. label Jul 28, 2022
@deepthidevaki deepthidevaki self-assigned this Aug 1, 2022
@deepthidevaki deepthidevaki mentioned this issue Aug 1, 2022
Merged
10 tasks
@Zelldon Zelldon added the version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0 label Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deepthidevaki deepthidevaki

Labels
kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. version:8.1.0-alpha5 Marks an issue as being completely or in parts released in 8.1.0-alpha5 version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Notify checkpoint listeners after init and replay camunda/zeebe
2 participants
@deepthidevaki @Zelldon