Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reject create process instance command using logical transaction #9644

Closed
korthout opened this issue Jun 29, 2022 · 0 comments · Fixed by #10018
Closed

Reject create process instance command using logical transaction #9644

korthout opened this issue Jun 29, 2022 · 0 comments · Fixed by #10018
Assignees
@korthout
Labels
kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. version:8.1.0-alpha5 Marks an issue as being completely or in parts released in 8.1.0-alpha5 version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0

Comments

@korthout
Copy link
Member

Description

#9637 used a workaround to reject the Create Process Instance command when the engine fails to subscribe to the relevant catch events. The workaround is to throw an exception and let the ProcessingStateMachine handle the exception as an error. The workaround was necessary because of a lack of support for:

As soon as logical transactions are supported, we should use the logical transaction to rollback the changes and reject the command.
@korthout korthout added kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. team/process-automation labels Jun 29, 2022
@korthout korthout mentioned this issue Jun 29, 2022
Closed
30 tasks
@saig0 saig0 mentioned this issue Jul 6, 2022
Closed
@korthout korthout mentioned this issue Aug 5, 2022
Merged
10 tasks
@korthout korthout self-assigned this Aug 9, 2022
@Zelldon Zelldon added the version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0 label Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@korthout korthout

Labels
kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. version:8.1.0-alpha5 Marks an issue as being completely or in parts released in 8.1.0-alpha5 version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Try to handle expected error in record processor camunda/zeebe
4 participants
@menski @deepthidevaki @Zelldon @korthout