Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output mapping doesn't create an incident if a variable is missing #9543

Closed
saig0 opened this issue Jun 15, 2022 · 1 comment · Fixed by #9668
Closed

Output mapping doesn't create an incident if a variable is missing #9543

saig0 opened this issue Jun 15, 2022 · 1 comment · Fixed by #9668
Assignees
Labels
area/reliability Marks an issue as related to improving the reliability of our software (i.e. it behaves as expected) kind/bug Categorizes an issue or PR as a bug scope/broker Marks an issue or PR to appear in the broker section of the changelog severity/mid Marks a bug as having a noticeable impact but with a known workaround version:1.3.13 version:8.1.0-alpha4 version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0

Comments

@saig0
Copy link
Member

saig0 commented Jun 15, 2022

Describe the bug

I deployed a BPMN process with a task. The task has an output mapping that adds (or updates) a property of a variable a.b.

image

Now, the job of the task is completed (accidentally) without the variable x that is referenced as the variable assignment value.

If the process instance doesn't have the variable a then an incident is created, as expected. The incident has the following error message:

failed to evaluate expression '{a:if (a = null) then {b: x} else put all(a,{b: x})}': no variable found for name 'x'

But if the process instance has the variable a then no incident is created. Instead, the variable a is set to null and the task is completed.

image

To Reproduce

  1. Deploy the BPMN process: output_mapping.bpmn.txt (without the .txt ending)
  2. Create a new process instance with the variables { "a": { "c": 1 } }
  3. Complete the task with job type task-a without variables
  4. Verify that no incident is created and the task is completed

Expected behavior

An incident is created if a job is completed without a variable that is referenced as the variable assignment value of an output mapping.

The behavior should be consistent. For the case that the variable is present and the case that the variable is not present.

Log/Stacktrace

None.

Environment:

  • OS:
  • Zeebe Version: 8.0.2
  • Configuration:
@saig0 saig0 added kind/bug Categorizes an issue or PR as a bug scope/broker Marks an issue or PR to appear in the broker section of the changelog severity/mid Marks a bug as having a noticeable impact but with a known workaround area/reliability Marks an issue as related to improving the reliability of our software (i.e. it behaves as expected) team/process-automation labels Jun 15, 2022
@saig0
Copy link
Member Author

saig0 commented Jun 16, 2022

The issue was reported on the forum: https://forum.camunda.io/t/timer-boundary-event-deletes-variable/38032

zeebe-bors-camunda bot added a commit that referenced this issue Jul 5, 2022
9696: [Backport stable/8.0] Escalate errors in output mapping evaluation r=pihme a=backport-action

# Description
Backport of #9668 to `stable/8.0`.

relates to #9543

Co-authored-by: pihme <pihme@users.noreply.github.com>
zeebe-bors-camunda bot added a commit that referenced this issue Jul 5, 2022
9695: [Backport stable/1.3] Escalate errors in output mapping evaluation r=pihme a=backport-action

# Description
Backport of #9668 to `stable/1.3`.

relates to #9543

Co-authored-by: pihme <pihme@users.noreply.github.com>
zeebe-bors-camunda bot added a commit that referenced this issue Jul 5, 2022
9696: [Backport stable/8.0] Escalate errors in output mapping evaluation r=pihme a=backport-action

# Description
Backport of #9668 to `stable/8.0`.

relates to #9543

Co-authored-by: pihme <pihme@users.noreply.github.com>
zeebe-bors-camunda bot added a commit that referenced this issue Jul 5, 2022
9695: [Backport stable/1.3] Escalate errors in output mapping evaluation r=pihme a=backport-action

# Description
Backport of #9668 to `stable/1.3`.

relates to #9543

Co-authored-by: pihme <pihme@users.noreply.github.com>
zeebe-bors-camunda bot added a commit that referenced this issue Jul 5, 2022
9696: [Backport stable/8.0] Escalate errors in output mapping evaluation r=pihme a=backport-action

# Description
Backport of #9668 to `stable/8.0`.

relates to #9543

Co-authored-by: pihme <pihme@users.noreply.github.com>
@Zelldon Zelldon added the version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0 label Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/reliability Marks an issue as related to improving the reliability of our software (i.e. it behaves as expected) kind/bug Categorizes an issue or PR as a bug scope/broker Marks an issue or PR to appear in the broker section of the changelog severity/mid Marks a bug as having a noticeable impact but with a known workaround version:1.3.13 version:8.1.0-alpha4 version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants