Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport stable/8.0] Set zbctl user agent #9468

Merged
merged 2 commits into from May 31, 2022
Merged

[Backport stable/8.0] Set zbctl user agent #9468

merged 2 commits into from May 31, 2022

Conversation

backport-action
Copy link
Collaborator

Description

Backport of #9434 to stable/8.0.

relates to

@Zelldon @github-actions
feat: set zbctl user agent
823bc5e 
In order to distinguish between go-client and zbctl add a new possibility to set the UserAgent as client config.
Zbctl use that config and set their own user agent header.

This is useful to understand which client types and versions are mostly used.

(cherry picked from commit 329884a)
@Zelldon @github-actions
fix: rm unused var
f4212d5 
(cherry picked from commit 287560a)
@backport-action backport-action mentioned this pull request May 31, 2022
Merged
10 tasks
@Zelldon
Copy link
Member

Zelldon commented May 31, 2022

bors r+

@zeebe-bors-camunda
Copy link
Contributor

👎 Rejected by too few approved reviews

Zelldon
Zelldon approved these changes May 31, 2022
View reviewed changes
Copy link
Member

@Zelldon Zelldon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

zeebe-bors-camunda bot added a commit that referenced this pull request May 31, 2022
@zeebe-bors-camunda @Zelldon
merge: #9468
8456800 
9468: [Backport stable/8.0] Set zbctl user agent r=Zelldon a=backport-action

# Description
Backport of #9434 to `stable/8.0`.

relates to 

Co-authored-by: Christopher Zell <zelldon91@googlemail.com>
@zeebe-bors-camunda
Copy link
Contributor

Build failed:

@Zelldon
Copy link
Member

Zelldon commented May 31, 2022

bors r+

@zeebe-bors-camunda
Copy link
Contributor

Build succeeded:

@zeebe-bors-camunda zeebe-bors-camunda bot merged commit 06e2b77 into stable/8.0 May 31, 2022
@zeebe-bors-camunda zeebe-bors-camunda bot deleted the backport-9434-to-stable/8.0 branch May 31, 2022 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zelldon Zelldon Zelldon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@backport-action @Zelldon