New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Toggles #9254
Labels
kind/feature
Categorizes an issue or PR as a feature, i.e. new behavior
version:8.1.0-alpha2
version:8.1.0
Marks an issue as being completely or in parts released in 8.1.0
Comments
pihme
added
the
kind/feature
Categorizes an issue or PR as a feature, i.e. new behavior
label
Apr 29, 2022
Implementation Approach
This assumes that feature toggles are only temporary (that's why it's under experimental configuration) |
Looks good to me. What would that look like in practice? zeebe:
broker:
experimental:
features:
myCoolFeature: false or zeebe:
broker:
experimental:
flags:
myCoolFeatureFlag: false So all environment variables would also be something like |
Don't know yet. I guess we will finalize that in the review :-) |
10 tasks
zeebe-bors-camunda bot
added a commit
that referenced
this issue
May 2, 2022
9257: feat(broker): add feature flag template r=pihme a=pihme ## Description Adds template to add feature flags. The template consists of two parts: * `FeatureFlags` to hold the flags and default values. Visible in most of the code base * `FeatureFlagsCfg` to make feature flags configurable. Instances of this class can be used to obtain a `FeatureFlags` object ## Review Hints * I did try to implement reflection based tests to check that e.g. the cfg object and the feature flags object have the same getters, and that values are passed in correctly. However, this spiraled out of control into a big chunk of over-engineered tests. So I dropped these completely * Secondly there are often config tests like `ExperimentalCfgTest` not sure if these add value. Let me know if you miss them as part of the template * Overall, this is a minimal implementation. Please let me know if you want to change any names or such things. ## Related issues closes #9254 Co-authored-by: pihme <pihme@users.noreply.github.com>
Zelldon
added
the
version:8.1.0
Marks an issue as being completely or in parts released in 8.1.0
label
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
kind/feature
Categorizes an issue or PR as a feature, i.e. new behavior
version:8.1.0-alpha2
version:8.1.0
Marks an issue as being completely or in parts released in 8.1.0
Is your feature request related to a problem? Please describe.
We are using feature toggles more frequently now. But there currently is no standardized way to define a feature toggle.
This makes implementing a feature toggle for a certain feature take more effort than necessary.
Describe the solution you'd like
Describe alternatives you've considered
Adding https://www.togglz.org/quickstart.html as a dependency. However, this doesn't integrate nicely with what we have already. Also it would add a number of transitive dependencies.
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: